[GeoMechanicsApplication] Line interface geometry can now generate edges #12684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nodes of the first edge are identical to the nodes of the first side. The nodes of the second edge have the end nodes swapped and any high-order nodes are reversed.
rfaasse
reviewed
Sep 19, 2024
...ations/GeoMechanicsApplication/tests/cpp_tests/custom_geometries/test_interface_geometry.cpp
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_geometries/line_interface_geometry.h
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_geometries/README.md
Outdated
Show resolved
Hide resolved
- Split a unit test case to be consistent with other test cases. - Be more explicit about the top and bottom sides of the line interface geometry in the documentation.
rfaasse
previously approved these changes
Sep 19, 2024
applications/GeoMechanicsApplication/custom_geometries/line_interface_geometry.h
Show resolved
Hide resolved
WPK4FEM
reviewed
Sep 19, 2024
applications/GeoMechanicsApplication/custom_geometries/line_interface_geometry.h
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_geometries/line_interface_geometry.h
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_geometries/line_interface_geometry.h
Show resolved
Hide resolved
Clarified the opposite orientation of the geometry's second edge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
The new line interface geometry now supports generating its edges. Note the that first edge's points are identical to the points of the first side. The second edge's points reference the points at the second side. However, since this edge has opposite orientation, the end points will be swapped and any intermediate points will be reversed, too.