Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GeoMechanicsApplication] Make element provided strain the default for our constitutive laws #12754

Conversation

rfaasse
Copy link
Contributor

@rfaasse rfaasse commented Oct 14, 2024

Currently, we have to provide the flag USE_ELEMENT_PROVIDED_STRAIN to our constitutive laws. However, as we have made the decision in Geo that the constitutive laws are only responsible for calculating stresses/constitutive matrices from input strains (see #12719), this should be the default behavior.

@rfaasse rfaasse requested a review from avdg81 October 15, 2024 09:27
@rfaasse rfaasse enabled auto-merge (squash) October 15, 2024 09:27
Copy link
Contributor

@avdg81 avdg81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small yet nice improvement (including a unit test) of the code base. Thank you for having taken this up.

@rfaasse rfaasse merged commit 156cc0f into master Oct 15, 2024
9 of 11 checks passed
@rfaasse rfaasse deleted the geo/12753-make-element-provided-strain-the-default-for-our-constitutive-laws branch October 15, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GeoMechanicsApplication] Make sure using element provided strain is the default for our constitutive laws
2 participants