[Core] Remove unused members from containers #12767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param r The GlobalPointersVector to compare with. | ||
| * @return True if the containers are equal, false otherwise. | ||
| */ | ||
| bool operator==(const GlobalPointersVector& r) const // nothrow |
There was a problem hiding this comment.
hi @matekelemen it looks to me that the comparison would make sense (provided it compiles of couse)
wouldn't it be better to implement the EqualKeyTo rather than removing the method?
There was a problem hiding this comment.
Well, I don't see a use case for comparing the contents of entire containers that wouldn't be possible with std::equal, but in any case, I implemented the function then.
RiccardoRossi
approved these changes
Oct 24, 2024
|
oh well ... if others (@KratosMultiphysics/technical-committee ) are in favor of removing no further resistance on my side ... |
|
No no it's fine. I doubt anyone'll use it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GlobalPointersVectorandPointerVectorreferred toEqualKeyToobjects/members that don't exist.This hasn't been a problem until now because these classes are templated and the member functions that referenced
EqualKeyToweren't used and so have never been instantiated. However, it seems like recent compiler versions (e.g.: clang19) introduced some static template analysis that catch this error.