[OptApp] adding QNBB shape vector support #12804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Igarizza
changed the title
Igarizza
changed the title
sunethwarna
reviewed
Oct 30, 2024
applications/OptimizationApplication/python_scripts/utilities/opt_line_search.py
Outdated
Show resolved
Hide resolved
Comment on lines
159
to
165
| if isinstance(d[i], (float, int, numpy.float64)): | ||
| if self.step_numpy[i] > self._max_step / norm: | ||
| self.step_numpy[i] = self._max_step / norm | ||
| elif isinstance(d[i], (numpy.ndarray)): | ||
| if self.step_numpy[i][0] > self._max_step / norm: | ||
| self.step_numpy[i] = self._max_step / norm | ||
|
|
There was a problem hiding this comment.
if statement doesn't work with vector data correctly
sunethwarna
approved these changes
Oct 31, 2024
|
|
||
| if isinstance(d[i], (float, int, numpy.float64)) and self.step_numpy[i] > self._max_step / norm: | ||
| self.step_numpy[i] = self._max_step / norm | ||
| elif isinstance(d[i], (numpy.ndarray)) and self.step_numpy[i][0] > self._max_step / norm: |
There was a problem hiding this comment.
Woudn't it be better to use a norm like L2 in here instead of checking the first entry?
There was a problem hiding this comment.
You can see, that all 3 positions have the same value, hence 1 Alfa for x y z. So, I can check the first value or check l2 norm. If we check l2 norm we need to give max step * sqrt(3) to have the same behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This pull request includes changes to enhance the
ComputeStepmethod in theopt_line_search.pyfile. The main improvement is the addition of type checks for elements in thedarray to handle both scalar and array types correctly.🆕 Changelog
Enhancements to
ComputeStepmethodapplications/OptimizationApplication/python_scripts/utilities/opt_line_search.py: Added type checks to handlefloat,int,numpy.float64, andnumpy.ndarraytypes separately, ensuring correct computation ofdyandddvalues and appropriate updates toself.step_numpy.