Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GeoMechanicsApplication] Fixed invalid values for default linear solver settings #12815

Merged
merged 4 commits into from
Nov 1, 2024
Merged

[GeoMechanicsApplication] Fixed invalid values for default linear solver settings #12815

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
17f3fd5
Used valid values for default linear solver settings
rfaasse Nov 1, 2024
48438fb
Revert "Used valid values for default linear solver settings"
rfaasse Nov 1, 2024
ea767d3
Used valid values for default linear solver settings (by changing as …
rfaasse Nov 1, 2024
fb1fa44
Removed explicit linear solver settings that were identical to the de…
avdg81 Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions applications/GeoMechanicsApplication/python_scripts/geomechanics_Pw_solver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,15 +75,14 @@ def GetDefaultParameters(cls):
"block_builder" : true,
"search_neighbours_step" : false,
"linear_solver_settings":{
"solver_type": "AMGCL",
"tolerance": 1.0e-6,
"max_iteration": 100,
"scaling": false,
"verbosity": 0,
"preconditioner_type": "ILU0Preconditioner",
"smoother_type": "ilu0",
"krylov_type": "gmres",
"coarsening_type": "aggregation"
"solver_type": "amgcl",
"smoother_type": "ilu0",
"krylov_type": "gmres",
"coarsening_type": "aggregation",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The precconditioner_type is missing here. Maybe it is wise to do the lower case of AMGCL as only change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I reverted everything that wasn't related, just did the lower case amgcl, however then we get the following problem:

RuntimeError: Error: AMGCL Linear Solver : preconditioner_type is invalid!
Currently prescribed preconditioner_type : ILU0Preconditioner
Admissible values are :
    amg
    dummy
    relaxation

So I changed that to amg

"max_iteration": 100,
"verbosity": 0,
"tolerance": 1.0e-6,
"scaling": false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course we can discuss if these are the best defaults we can think of, I just took the settings of one of our tests. I first tried sparse_lu, but I don't think it's always guaranteed that the LinearSolversApplication is initialized, so not sure if that's the most robust option for a default

},
"problem_domain_sub_model_part_list": [""],
"processes_sub_model_part_list": [""],
Expand Down
17 changes: 8 additions & 9 deletions applications/GeoMechanicsApplication/python_scripts/geomechanics_T_solver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,15 +65,14 @@ def GetDefaultParameters(cls):
"block_builder" : true,
"search_neighbours_step" : false,
"linear_solver_settings":{
"solver_type": "AMGCL",
"tolerance": 1.0e-6,
"max_iteration": 100,
"scaling": false,
"verbosity": 0,
"preconditioner_type": "ILU0Preconditioner",
"smoother_type": "ilu0",
"krylov_type": "gmres",
"coarsening_type": "aggregation"
"solver_type": "amgcl",
"smoother_type": "ilu0",
"krylov_type": "gmres",
"coarsening_type": "aggregation",
"max_iteration": 100,
"verbosity": 0,
"tolerance": 1.0e-6,
"scaling": false
},
"problem_domain_sub_model_part_list": [""],
"processes_sub_model_part_list": [""],
Expand Down
17 changes: 8 additions & 9 deletions applications/GeoMechanicsApplication/python_scripts/geomechanics_U_Pw_solver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,15 +81,14 @@ def GetDefaultParameters(cls):
"prebuild_dynamics" : false,
"search_neighbours_step" : false,
"linear_solver_settings":{
"solver_type": "AMGCL",
"tolerance": 1.0e-6,
"max_iteration": 100,
"scaling": false,
"verbosity": 0,
"preconditioner_type": "ILU0Preconditioner",
"smoother_type": "ilu0",
"krylov_type": "gmres",
"coarsening_type": "aggregation"
"solver_type": "amgcl",
"smoother_type": "ilu0",
"krylov_type": "gmres",
"coarsening_type": "aggregation",
"max_iteration": 100,
"verbosity": 0,
"tolerance": 1.0e-6,
"scaling": false
},
"problem_domain_sub_model_part_list": [""],
"processes_sub_model_part_list": [""],
Expand Down
17 changes: 8 additions & 9 deletions applications/GeoMechanicsApplication/python_scripts/geomechanics_solver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,15 +117,14 @@ def GetDefaultParameters(cls):
"prebuild_dynamics" : false,
"search_neighbours_step" : false,
"linear_solver_settings":{
"solver_type": "AMGCL",
"tolerance": 1.0e-6,
"max_iteration": 100,
"scaling": false,
"verbosity": 0,
"preconditioner_type": "ILU0Preconditioner",
"smoother_type": "ilu0",
"krylov_type": "gmres",
"coarsening_type": "aggregation"
"solver_type": "amgcl",
"smoother_type": "ilu0",
"krylov_type": "gmres",
"coarsening_type": "aggregation",
"max_iteration": 100,
"verbosity": 0,
"tolerance": 1.0e-6,
"scaling": false
},
"problem_domain_sub_model_part_list": [""],
"processes_sub_model_part_list": [""],
Expand Down
Loading