Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GeoMechanicsApplication] A 3D elastic constitutive law is lacking in GeoMechanicsApplication #12816

Merged
merged 14 commits into from
Nov 8, 2024
Merged

[GeoMechanicsApplication] A 3D elastic constitutive law is lacking in GeoMechanicsApplication #12816

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
2ce1e36
renamed GeoLinearElasticPlaneStrain2DLaw to GeoIncrementalLinerLaw
markelov208 Nov 1, 2024
c6e43b4
added elastic_3D law and unit tests
markelov208 Nov 1, 2024
27e4090
clang-format
markelov208 Nov 1, 2024
e927d15
used GeoLinearElastic3DLaw
markelov208 Nov 1, 2024
82fe15f
Merge branch 'master' into geo/12814_3D_elastic_constitutive_law
markelov208 Nov 4, 2024
9889c47
Merge branch 'master' into geo/12814_3D_elastic_constitutive_law
markelov208 Nov 4, 2024
8ce1180
fixed comments
markelov208 Nov 5, 2024
b683398
used GeoIncrementalLinearElastic3DLaw
markelov208 Nov 5, 2024
95893d9
response to reviews
markelov208 Nov 5, 2024
b081e1e
Merge branch 'master' into geo/12814_3D_elastic_constitutive_law
markelov208 Nov 5, 2024
96954f7
formatted
markelov208 Nov 5, 2024
4077a4a
Merge branch 'master' into geo/12814_3D_elastic_constitutive_law
markelov208 Nov 8, 2024
7477196
fixed an
markelov208 Nov 8, 2024
2d19354
removed two lines with ///
markelov208 Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 56 additions & 0 deletions applications/GeoMechanicsApplication/custom_constitutive/elastic_3D.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
// KRATOS___
// // ) )
// // ___ ___
// // ____ //___) ) // ) )
// // / / // // / /
// ((____/ / ((____ ((___/ / MECHANICS
//
// License: geo_mechanics_application/license.txt
//
// Main authors: Richard Faasse
// Gennady Markelov
//

#include "elastic_3D.h"

#include "geo_mechanics_application_constants.h"
#include "includes/constitutive_law.h"

namespace Kratos
{

Matrix Elastic3D::FillConstitutiveMatrix(double c1, double c2, double c3) const
{
Matrix result = ZeroMatrix(GetStrainSize(), GetStrainSize());

result(INDEX_3D_XX, INDEX_3D_XX) = c1;
result(INDEX_3D_XX, INDEX_3D_YY) = c2;
result(INDEX_3D_XX, INDEX_3D_ZZ) = c2;

result(INDEX_3D_YY, INDEX_3D_XX) = c2;
result(INDEX_3D_YY, INDEX_3D_YY) = c1;
result(INDEX_3D_YY, INDEX_3D_ZZ) = c2;

result(INDEX_3D_ZZ, INDEX_3D_XX) = c2;
result(INDEX_3D_ZZ, INDEX_3D_YY) = c2;
result(INDEX_3D_ZZ, INDEX_3D_ZZ) = c1;

result(INDEX_3D_XY, INDEX_3D_XY) = c3;
result(INDEX_3D_YZ, INDEX_3D_YZ) = c3;
result(INDEX_3D_XZ, INDEX_3D_XZ) = c3;

return result;
}

std::unique_ptr<ConstitutiveLawDimension> Elastic3D::Clone() const
{
return std::make_unique<Elastic3D>();
}

std::size_t Elastic3D::GetStrainSize() const { return VOIGT_SIZE_3D; }

std::size_t Elastic3D::GetDimension() const { return N_DIM_3D; }

Flags Elastic3D::GetSpatialType() const { return ConstitutiveLaw::THREE_DIMENSIONAL_LAW; }

} // namespace Kratos
31 changes: 31 additions & 0 deletions applications/GeoMechanicsApplication/custom_constitutive/elastic_3D.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
// KRATOS___
// // ) )
// // ___ ___
// // ____ //___) ) // ) )
// // / / // // / /
// ((____/ / ((____ ((___/ / MECHANICS
//
// License: geo_mechanics_application/license.txt
//
// Main authors: Richard Faasse
// Gennady Markelov
//

#pragma once

#include "constitutive_law_dimension.h"
avdg81 marked this conversation as resolved.
Show resolved Hide resolved

namespace Kratos
{

class KRATOS_API(GEO_MECHANICS_APPLICATION) Elastic3D : public ConstitutiveLawDimension
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm doubting a bit about the name of the class, the plane strain counterpart is just called PlaneStrain, but I'm not sure if ThreeDimensional would be descriptive enough.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor of renaming this class to ThreeDimensional. Needless to say that we then also need to rename this header file as well as the corresponding implementation file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do @rfaasse and @WPK4FEM think about ElasticIsotropic3D and to change ConstitutiveLawDimension to ConstitutiveLawType? For example, there is GeoLinearElasticPlaneStress2DLaw which fits this structure perfectly using PlaneStress like PlaneStrain. Another candidate is ElasticIsotropicK03DLaw. Thank you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to ThreeDimensional. However, looking to a discussion on my suggestion. ;)

{
public:
[[nodiscard]] Matrix FillConstitutiveMatrix(double c1, double c2, double c3) const override;
[[nodiscard]] std::unique_ptr<ConstitutiveLawDimension> Clone() const override;
[[nodiscard]] std::size_t GetStrainSize() const override;
[[nodiscard]] std::size_t GetDimension() const override;
[[nodiscard]] Flags GetSpatialType() const override;
};

} // namespace Kratos
53 changes: 26 additions & 27 deletions ...ve/linear_elastic_plane_strain_2D_law.cpp → ...tutive/incremental_linear_elastic_law.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,16 @@
// Main authors: Wijtze Pieter Kikstra
// Richard Faasse

#include "custom_constitutive/linear_elastic_plane_strain_2D_law.h"
#include "custom_constitutive/incremental_linear_elastic_law.h"
#include "constitutive_law_dimension.h"
#include "geo_mechanics_application_variables.h"

namespace Kratos
{

GeoLinearElasticPlaneStrain2DLaw::GeoLinearElasticPlaneStrain2DLaw() = default;
GeoIncrementalLinearElasticLaw::GeoIncrementalLinearElasticLaw() = default;

GeoLinearElasticPlaneStrain2DLaw::GeoLinearElasticPlaneStrain2DLaw(std::unique_ptr<ConstitutiveLawDimension> pConstitutiveDimension)
GeoIncrementalLinearElasticLaw::GeoIncrementalLinearElasticLaw(std::unique_ptr<ConstitutiveLawDimension> pConstitutiveDimension)
: GeoLinearElasticLaw{},
mpConstitutiveDimension(std::move(pConstitutiveDimension)),
mStressVector(ZeroVector(mpConstitutiveDimension->GetStrainSize())),
Expand All @@ -29,7 +29,7 @@ GeoLinearElasticPlaneStrain2DLaw::GeoLinearElasticPlaneStrain2DLaw(std::unique_p
{
}

GeoLinearElasticPlaneStrain2DLaw::GeoLinearElasticPlaneStrain2DLaw(const GeoLinearElasticPlaneStrain2DLaw& rOther)
GeoIncrementalLinearElasticLaw::GeoIncrementalLinearElasticLaw(const GeoIncrementalLinearElasticLaw& rOther)
: GeoLinearElasticLaw(rOther),
mStressVector(rOther.mStressVector),
mStressVectorFinalized(rOther.mStressVectorFinalized),
Expand All @@ -41,7 +41,7 @@ GeoLinearElasticPlaneStrain2DLaw::GeoLinearElasticPlaneStrain2DLaw(const GeoLine
mpConstitutiveDimension = rOther.mpConstitutiveDimension->Clone();
}

GeoLinearElasticPlaneStrain2DLaw& GeoLinearElasticPlaneStrain2DLaw::operator=(const GeoLinearElasticPlaneStrain2DLaw& rOther)
GeoIncrementalLinearElasticLaw& GeoIncrementalLinearElasticLaw::operator=(const GeoIncrementalLinearElasticLaw& rOther)
{
GeoLinearElasticLaw::operator=(rOther);
mStressVector = rOther.mStressVector;
Expand All @@ -55,24 +55,23 @@ GeoLinearElasticPlaneStrain2DLaw& GeoLinearElasticPlaneStrain2DLaw::operator=(co
return *this;
}

GeoLinearElasticPlaneStrain2DLaw::GeoLinearElasticPlaneStrain2DLaw(GeoLinearElasticPlaneStrain2DLaw&& rOther) noexcept = default;
GeoLinearElasticPlaneStrain2DLaw& GeoLinearElasticPlaneStrain2DLaw::operator=(
GeoLinearElasticPlaneStrain2DLaw&& rOther) noexcept = default;
GeoLinearElasticPlaneStrain2DLaw::~GeoLinearElasticPlaneStrain2DLaw() = default;
GeoIncrementalLinearElasticLaw::GeoIncrementalLinearElasticLaw(GeoIncrementalLinearElasticLaw&& rOther) noexcept = default;
GeoIncrementalLinearElasticLaw& GeoIncrementalLinearElasticLaw::operator=(GeoIncrementalLinearElasticLaw&& rOther) noexcept = default;
GeoIncrementalLinearElasticLaw::~GeoIncrementalLinearElasticLaw() = default;

ConstitutiveLaw::Pointer GeoLinearElasticPlaneStrain2DLaw::Clone() const
ConstitutiveLaw::Pointer GeoIncrementalLinearElasticLaw::Clone() const
{
return Kratos::make_shared<GeoLinearElasticPlaneStrain2DLaw>(*this);
return Kratos::make_shared<GeoIncrementalLinearElasticLaw>(*this);
}

bool& GeoLinearElasticPlaneStrain2DLaw::GetValue(const Variable<bool>& rThisVariable, bool& rValue)
bool& GeoIncrementalLinearElasticLaw::GetValue(const Variable<bool>& rThisVariable, bool& rValue)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should find out what Stenberg shear stabilization is and whether it is applicable for elasticity. We are moving this around, but we are not really using it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked at Stenberg stabilization. Only seems applicable for thick shell formulation used in Structural Mechanics Applications. I consider it to be part of another PR to limit its use to meaningful use in GeoMechanics.

{
// This Constitutive Law has been checked with Stenberg Stabilization
if (rThisVariable == STENBERG_SHEAR_STABILIZATION_SUITABLE) rValue = true;
return rValue;
}

void GeoLinearElasticPlaneStrain2DLaw::GetLawFeatures(Features& rFeatures)
void GeoIncrementalLinearElasticLaw::GetLawFeatures(Features& rFeatures)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation reads like SetFeatureOptions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed ;) It is used across Kratos.

{
rFeatures.mOptions.Set(mpConstitutiveDimension->GetSpatialType());
rFeatures.mOptions.Set(INFINITESIMAL_STRAINS);
Expand All @@ -85,19 +84,19 @@ void GeoLinearElasticPlaneStrain2DLaw::GetLawFeatures(Features& rFeatures)
rFeatures.mSpaceDimension = WorkingSpaceDimension();
}

SizeType GeoLinearElasticPlaneStrain2DLaw::WorkingSpaceDimension()
SizeType GeoIncrementalLinearElasticLaw::WorkingSpaceDimension()
{
return mpConstitutiveDimension->GetDimension();
}

SizeType GeoLinearElasticPlaneStrain2DLaw::GetStrainSize() const
SizeType GeoIncrementalLinearElasticLaw::GetStrainSize() const
{
return mpConstitutiveDimension->GetStrainSize();
}

bool GeoLinearElasticPlaneStrain2DLaw::IsIncremental() { return true; }
bool GeoIncrementalLinearElasticLaw::IsIncremental() { return true; }

void GeoLinearElasticPlaneStrain2DLaw::CalculateElasticMatrix(Matrix& C, ConstitutiveLaw::Parameters& rValues)
void GeoIncrementalLinearElasticLaw::CalculateElasticMatrix(Matrix& C, ConstitutiveLaw::Parameters& rValues)
{
KRATOS_TRY

Expand All @@ -115,9 +114,9 @@ void GeoLinearElasticPlaneStrain2DLaw::CalculateElasticMatrix(Matrix& C, Constit
KRATOS_CATCH("")
}

void GeoLinearElasticPlaneStrain2DLaw::CalculatePK2Stress(const Vector& rStrainVector,
Vector& rStressVector,
ConstitutiveLaw::Parameters& rValues)
void GeoIncrementalLinearElasticLaw::CalculatePK2Stress(const Vector& rStrainVector,
Vector& rStressVector,
ConstitutiveLaw::Parameters& rValues)
{
KRATOS_TRY

Expand All @@ -134,9 +133,9 @@ void GeoLinearElasticPlaneStrain2DLaw::CalculatePK2Stress(const Vector& rStrainV
KRATOS_CATCH("")
}

bool GeoLinearElasticPlaneStrain2DLaw::RequiresInitializeMaterialResponse() { return true; }
bool GeoIncrementalLinearElasticLaw::RequiresInitializeMaterialResponse() { return true; }

void GeoLinearElasticPlaneStrain2DLaw::InitializeMaterialResponseCauchy(ConstitutiveLaw::Parameters& rValues)
void GeoIncrementalLinearElasticLaw::InitializeMaterialResponseCauchy(ConstitutiveLaw::Parameters& rValues)
{
KRATOS_TRY
if (!mIsModelInitialized) {
Expand All @@ -148,21 +147,21 @@ void GeoLinearElasticPlaneStrain2DLaw::InitializeMaterialResponseCauchy(Constitu
KRATOS_CATCH("")
}

bool GeoLinearElasticPlaneStrain2DLaw::RequiresFinalizeMaterialResponse() { return true; }
bool GeoIncrementalLinearElasticLaw::RequiresFinalizeMaterialResponse() { return true; }

void GeoLinearElasticPlaneStrain2DLaw::FinalizeMaterialResponseCauchy(ConstitutiveLaw::Parameters& rValues)
void GeoIncrementalLinearElasticLaw::FinalizeMaterialResponseCauchy(ConstitutiveLaw::Parameters& rValues)
{
mStrainVectorFinalized = rValues.GetStrainVector();
mStressVectorFinalized = mStressVector;
}

void GeoLinearElasticPlaneStrain2DLaw::FinalizeMaterialResponsePK2(ConstitutiveLaw::Parameters& rValues)
void GeoIncrementalLinearElasticLaw::FinalizeMaterialResponsePK2(ConstitutiveLaw::Parameters& rValues)
{
// Small deformation so we can call the Cauchy method
FinalizeMaterialResponseCauchy(rValues);
}

void GeoLinearElasticPlaneStrain2DLaw::save(Serializer& rSerializer) const
void GeoIncrementalLinearElasticLaw::save(Serializer& rSerializer) const
{
KRATOS_SERIALIZE_SAVE_BASE_CLASS(rSerializer, GeoLinearElasticLaw)
rSerializer.save("StressVector", mStressVector);
Expand All @@ -172,7 +171,7 @@ void GeoLinearElasticPlaneStrain2DLaw::save(Serializer& rSerializer) const
rSerializer.save("mIsModelInitialized", mIsModelInitialized);
}

void GeoLinearElasticPlaneStrain2DLaw::load(Serializer& rSerializer)
void GeoIncrementalLinearElasticLaw::load(Serializer& rSerializer)
{
KRATOS_SERIALIZE_LOAD_BASE_CLASS(rSerializer, GeoLinearElasticLaw)
rSerializer.load("StressVector", mStressVector);
Expand Down
24 changes: 12 additions & 12 deletions ...tive/linear_elastic_plane_strain_2D_law.h → ...titutive/incremental_linear_elastic_law.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,27 +21,27 @@ namespace Kratos
class ConstitutiveLawDimension;

/**
* @class GeoLinearElasticPlaneStrain2DLaw
* @class GeoIncrementalLinearElasticLaw
* @ingroup GeoMechanicsApplication
* @brief This class defines a small deformation linear elastic constitutive model for plane strain cases
* @brief This class defines a small deformation linear elastic constitutive model for plane strain and 3D cases
* @author Vahid Galavi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be re-written a bit more (as you already started doing so): I'd propose something like:
This class defines an incremental linear elastic constitutive model for plane strain and 3D cases.

I don't think that 'small deformation' is really accurate (or has anything to do with the linear elastic model), but please correct me if I'm wrong (tagging you @WPK4FEM, to hear your opinion on this as well)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To stress the incremental nature of the implementation, we could replace "small deformation" with "incremental". The formulation can be used both for small deformation and large deformation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replaced small deformation with incremental

*/
class KRATOS_API(GEO_MECHANICS_APPLICATION) GeoLinearElasticPlaneStrain2DLaw : public GeoLinearElasticLaw
class KRATOS_API(GEO_MECHANICS_APPLICATION) GeoIncrementalLinearElasticLaw : public GeoLinearElasticLaw
{
public:
using BaseType = GeoLinearElasticLaw;
using SizeType = std::size_t;

KRATOS_CLASS_POINTER_DEFINITION(GeoLinearElasticPlaneStrain2DLaw);
GeoLinearElasticPlaneStrain2DLaw();
KRATOS_CLASS_POINTER_DEFINITION(GeoIncrementalLinearElasticLaw);
GeoIncrementalLinearElasticLaw();

explicit GeoLinearElasticPlaneStrain2DLaw(std::unique_ptr<ConstitutiveLawDimension> pConstitutiveDimension);
GeoLinearElasticPlaneStrain2DLaw(const GeoLinearElasticPlaneStrain2DLaw& rOther);
GeoLinearElasticPlaneStrain2DLaw& operator=(const GeoLinearElasticPlaneStrain2DLaw& rOther);
explicit GeoIncrementalLinearElasticLaw(std::unique_ptr<ConstitutiveLawDimension> pConstitutiveDimension);
GeoIncrementalLinearElasticLaw(const GeoIncrementalLinearElasticLaw& rOther);
GeoIncrementalLinearElasticLaw& operator=(const GeoIncrementalLinearElasticLaw& rOther);

GeoLinearElasticPlaneStrain2DLaw(GeoLinearElasticPlaneStrain2DLaw&& rOther) noexcept;
GeoLinearElasticPlaneStrain2DLaw& operator=(GeoLinearElasticPlaneStrain2DLaw&& rOther) noexcept;
~GeoLinearElasticPlaneStrain2DLaw() override;
GeoIncrementalLinearElasticLaw(GeoIncrementalLinearElasticLaw&& rOther) noexcept;
GeoIncrementalLinearElasticLaw& operator=(GeoIncrementalLinearElasticLaw&& rOther) noexcept;
~GeoIncrementalLinearElasticLaw() override;

[[nodiscard]] ConstitutiveLaw::Pointer Clone() const override;

Expand Down Expand Up @@ -112,6 +112,6 @@ class KRATOS_API(GEO_MECHANICS_APPLICATION) GeoLinearElasticPlaneStrain2DLaw : p
friend class Serializer;
void save(Serializer& rSerializer) const override;
void load(Serializer& rSerializer) override;
}; // Class GeoLinearElasticPlaneStrain2DLaw
}; // Class GeoIncrementalLinearElasticLaw

} // namespace Kratos
10 changes: 5 additions & 5 deletions applications/GeoMechanicsApplication/custom_constitutive/linear_elastic_2D_beam_law.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
#pragma once

// Project includes
#include "custom_constitutive/linear_elastic_plane_strain_2D_law.h"
#include "custom_constitutive/incremental_linear_elastic_law.h"

namespace Kratos
{
Expand Down Expand Up @@ -43,7 +43,7 @@ namespace Kratos
* @details This class derives from the linear elastic case on 3D
* @author Vahid Galavi
*/
class KRATOS_API(GEO_MECHANICS_APPLICATION) LinearElastic2DBeamLaw : public GeoLinearElasticPlaneStrain2DLaw
class KRATOS_API(GEO_MECHANICS_APPLICATION) LinearElastic2DBeamLaw : public GeoIncrementalLinearElasticLaw
{
public:
///@name Type Definitions
Expand All @@ -53,7 +53,7 @@ class KRATOS_API(GEO_MECHANICS_APPLICATION) LinearElastic2DBeamLaw : public GeoL
using CLBaseType = ConstitutiveLaw;

/// The base class ElasticIsotropicK03DLaw type definition
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rotting comment, was already wrong before the current change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected

using BaseType = GeoLinearElasticPlaneStrain2DLaw;
using BaseType = GeoIncrementalLinearElasticLaw;

/// The size type definition
using SizeType = std::size_t;
Expand Down Expand Up @@ -171,12 +171,12 @@ class KRATOS_API(GEO_MECHANICS_APPLICATION) LinearElastic2DBeamLaw : public GeoL

void save(Serializer& rSerializer) const override
{
KRATOS_SERIALIZE_SAVE_BASE_CLASS(rSerializer, GeoLinearElasticPlaneStrain2DLaw)
KRATOS_SERIALIZE_SAVE_BASE_CLASS(rSerializer, GeoIncrementalLinearElasticLaw)
avdg81 marked this conversation as resolved.
Show resolved Hide resolved
}

void load(Serializer& rSerializer) override
{
KRATOS_SERIALIZE_LOAD_BASE_CLASS(rSerializer, GeoLinearElasticPlaneStrain2DLaw)
KRATOS_SERIALIZE_LOAD_BASE_CLASS(rSerializer, GeoIncrementalLinearElasticLaw)
avdg81 marked this conversation as resolved.
Show resolved Hide resolved
}
}; // Class LinearElastic2DBeamLaw

Expand Down
12 changes: 6 additions & 6 deletions applications/GeoMechanicsApplication/custom_constitutive/linear_elastic_2D_interface_law.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
#pragma once

// Project includes
#include "custom_constitutive/linear_elastic_plane_strain_2D_law.h"
#include "custom_constitutive/incremental_linear_elastic_law.h"

namespace Kratos
{
Expand Down Expand Up @@ -43,7 +43,7 @@ namespace Kratos
* @details This class derives from the linear elastic case on 3D
* @author Vahid Galavi
*/
class KRATOS_API(GEO_MECHANICS_APPLICATION) LinearElastic2DInterfaceLaw : public GeoLinearElasticPlaneStrain2DLaw
class KRATOS_API(GEO_MECHANICS_APPLICATION) LinearElastic2DInterfaceLaw : public GeoIncrementalLinearElasticLaw
{
public:
///@name Type Definitions
Expand All @@ -53,7 +53,7 @@ class KRATOS_API(GEO_MECHANICS_APPLICATION) LinearElastic2DInterfaceLaw : public
using CLBaseType = ConstitutiveLaw;

/// The base class ElasticIsotropicK03DLaw type definition
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same wrong comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected

using BaseType = GeoLinearElasticPlaneStrain2DLaw;
using BaseType = GeoIncrementalLinearElasticLaw;

/// The size type definition
using SizeType = std::size_t;
Expand Down Expand Up @@ -120,7 +120,7 @@ class KRATOS_API(GEO_MECHANICS_APPLICATION) LinearElastic2DInterfaceLaw : public
* @param rValue a reference to the returned value
* @param rValue output: the value of the specified variable
*/
using GeoLinearElasticPlaneStrain2DLaw::GetValue;
using GeoIncrementalLinearElasticLaw::GetValue;
bool& GetValue(const Variable<bool>& rThisVariable, bool& rValue) override;

///@}
Expand Down Expand Up @@ -189,12 +189,12 @@ class KRATOS_API(GEO_MECHANICS_APPLICATION) LinearElastic2DInterfaceLaw : public

void save(Serializer& rSerializer) const override
{
KRATOS_SERIALIZE_SAVE_BASE_CLASS(rSerializer, GeoLinearElasticPlaneStrain2DLaw)
KRATOS_SERIALIZE_SAVE_BASE_CLASS(rSerializer, GeoIncrementalLinearElasticLaw)
avdg81 marked this conversation as resolved.
Show resolved Hide resolved
}

void load(Serializer& rSerializer) override
{
KRATOS_SERIALIZE_LOAD_BASE_CLASS(rSerializer, GeoLinearElasticPlaneStrain2DLaw)
KRATOS_SERIALIZE_LOAD_BASE_CLASS(rSerializer, GeoIncrementalLinearElasticLaw)
avdg81 marked this conversation as resolved.
Show resolved Hide resolved
}
}; // Class LinearElastic2DInterfaceLaw

Expand Down
1 change: 1 addition & 0 deletions applications/GeoMechanicsApplication/geo_mechanics_application.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,7 @@ void KratosGeoMechanicsApplication::Register()
KRATOS_REGISTER_CONSTITUTIVE_LAW("LinearElasticPlaneStrainK02DLaw", mLinearPlaneStrainK0Law)
KRATOS_REGISTER_CONSTITUTIVE_LAW("LinearElasticK03DLaw", mElasticIsotropicK03DLaw)
KRATOS_REGISTER_CONSTITUTIVE_LAW("GeoLinearElasticPlaneStrain2DLaw", mLinearElasticPlaneStrain2DLaw)
KRATOS_REGISTER_CONSTITUTIVE_LAW("GeoLinearElastic3DLaw", mLinearElastic3DLaw)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have the 'incremental' specifier in the registered name (maybe GeoIncrementalLinearElastic3DLaw?), but it's good to also have @WPK4FEM's opinion on this)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree to have "Incremental" in the registered name.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I share Richards point of view.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added Incremental


KRATOS_REGISTER_CONSTITUTIVE_LAW("GeoLinearElasticPlaneStress2DLaw", mLinearElasticPlaneStress2DLaw)

Expand Down
Loading
Loading