[GeoMechanicsApplication] First experiment with GMock #12841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfaasse
commented
Nov 11, 2024
| @@ -25,7 +25,7 @@ macro(kratos_add_gtests) | |||
| add_executable("${KRATOS_ADD_GTEST_TARGET}Test" ${KRATOS_ADD_GTEST_SOURCES} ${KRATOS_GTEST_MAIN_SOURCE}) | |||
| target_link_libraries("${KRATOS_ADD_GTEST_TARGET}Test" ${KRATOS_ADD_GTEST_TARGET} KratosCoreTestUtilities "${TESTING_MPI_UTILITIES}" GTest::gmock_main) | |||
| set_target_properties("${KRATOS_ADD_GTEST_TARGET}Test" PROPERTIES COMPILE_DEFINITIONS "KRATOS_TEST_CORE=IMPORT,API") | |||
|
|
|||
| target_compile_definitions("${KRATOS_ADD_GTEST_TARGET}Test" PUBLIC GTEST_LINKED_AS_SHARED_LIBRARY) | |||
There was a problem hiding this comment.
@roigcarlo It seems we need to set this compile definition since we're using GTest as a shared library (see e.g. https://stackoverflow.com/questions/46025439/unresolved-external-symbol-error-with-google-mock-and-vcpkg), otherwise I get linking errors when I try to use GMock
rfaasse
changed the title
avdg81
approved these changes
Nov 13, 2024
loumalouomega
pushed a commit
that referenced
this pull request
Nov 14, 2024
…dized GMock functionality for one set of unit tests (#12841)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR replaces manually created functions for two Mock/Stub/Spy classes with the MOCK_METHOD macro implemented in GMock. This has a couple of advantages:
EXPECT_CALL(*converging_strategy, Predict()).Times(1)), you can also control what it will output (for exampleEXPECT_CALL(*converging_strategy, GetNumberOfIterations()).WillOnce(testing::Return(4));orON_CALL(*this, GetNumberOfIterations()).WillByDefault(testing::Return(4));)