[GeoMechanicsApplication] Avoid hiding of overloaded virtual members
#12849
Conversation
…FluidFlux2DDiffOrderCondition`
…Load2DDiffOrderCondition`
…iffOrderCondition`
…3DDiffOrderCondition`
…fOrderCondition` Also reformatted three unrelated files.
…MAT2DInterfaceLaw`
…MAT2DPlaneStrainLaw`
…amElementLinear2D2N`
…amElementLinear3D2N`
…cturalBaseElement`
…LagrangianUPwDiffOrderElement`
applications/GeoMechanicsApplication/custom_conditions/U_Pw_condition.cpp
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_conditions/U_Pw_condition.cpp
Show resolved
Hide resolved
...pplication/custom_conditions/axisymmetric_line_normal_fluid_flux_2D_diff_order_condition.cpp
Show resolved
Hide resolved
| bool& GetValue(const Variable<bool>& rThisVariable, bool& rValue) override; | ||
| using LinearElastic2DInterfaceLaw::GetValue; |
There was a problem hiding this comment.
Looks like this is a candidate for using a plane strain and a 3D stress state.
There was a problem hiding this comment.
In fact, we may want to look into the differences with the recently introduced class GeoIncrementalLinearElasticInterfaceLaw, and discuss whether we'd still like to keep this class or replace it by the new one.
There was a problem hiding this comment.
You are right. These should disappear when we remove the interface elements that derive from planes i.s.o. 2 lines and volumes i.s.o. 2 planes. They use continuum material properties ( E, nu ) i.s.o. distributed stiffnesses that are natural for interfaces.
Thank you for the code review. I hope that my explanation (see below) is clear enough. If not, feel free to ask for clarification. |
📝 Description
SonarQube has found a significant number of code smells related to hiding of overloaded
virtualmembers. This PR adds overloads of membersCreatewhere needed. In other places,usingstatements were sufficient to overcome the issues.