-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register Single Precision Linear Solvers #13087
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks like every compiler is happy now. @loumalouomega can you please take a look again? I'd also appreciate if someone from the @KratosMultiphysics/technical-committee too could take a quick peek. |
// using LinearSolverType = LinearSolver<SpaceType, LocalSpaceType>; | ||
// using IterativeSolverType = IterativeSolver<SpaceType, LocalSpaceType>; | ||
using CGSolverType = CGSolver<SpaceType, LocalSpaceType>; | ||
using SpaceType = TUblasSparseSpace<TSparseDataType>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, we should eventually replace the linear solver factory with the register @KratosMultiphysics/technical-committee I don't know if a good moment to do that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about that too, but other parts of Kratos still expect linear solvers to be in KratosComponents
and I didn't want to change too many unrelated things at once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A priori we can define in both database and add a warning in the factory, opinion @KratosMultiphysics/technical-committee ?
@@ -541,6 +541,7 @@ class KRATOS_API(KRATOS_CORE) Serializer | |||
KRATOS_SERIALIZATION_DIRECT_LOAD(std::size_t) | |||
#endif | |||
KRATOS_SERIALIZATION_DIRECT_LOAD(std::complex<double>) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove those evil tabs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me ok, I just added 2 comments
This PR is a follow-up on #13079.
Changelog
double
as the value type in some functions.double
.Serializer
to supportstd::complex<float>
.