Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature migration cleanup #2

Merged
merged 5 commits into from
Feb 13, 2017
Merged

Feature migration cleanup #2

merged 5 commits into from
Feb 13, 2017

Conversation

roigcarlo
Copy link
Member

An initial PR with some git basics

@farrufat-cimne
Copy link
Member

Will this cause any conflict if other users already put this folders/files on the gitignore list?


# CMake directory
cmake_build/*
!cmake_build/example_configure.bat.do_not_touch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should ignore the history of configure.xxx.do_not_touch?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not. Notice the !
Basically I want to ignore everything there except those files

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I have not notice that!

@roigcarlo
Copy link
Member Author

@farrufat-cimne Since there were no other centralized .gitignore it is probable. But this is only a generic one. Feel free to add any other ignores here

@pooyan-dadvand
Copy link
Member

Instead of a branch with a generic clean up purpose I would suggest smaller one with more specific purposes.

@roigcarlo
Copy link
Member Author

Ok, maybe the name was misleading...

Copy link
Member

@pooyan-dadvand pooyan-dadvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@roigcarlo roigcarlo merged commit 1291506 into master Feb 13, 2017
@roigcarlo roigcarlo deleted the feature-migration-cleanup branch February 13, 2017 16:56
josep-m-carbonell pushed a commit that referenced this pull request Jun 22, 2017
…ments

Feature modify mixed elements + Constitutive equations.
BasselSaridar added a commit that referenced this pull request May 7, 2019
KlausBSautter added a commit to clazaro/Kratos that referenced this pull request Mar 28, 2023
rfaasse added a commit that referenced this pull request Nov 13, 2023
rfaasse added a commit that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants