Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poromechanics main python script rewritten as a class #2121

Closed
wants to merge 9 commits into from

Conversation

ipouplana
Copy link
Member

Essentially, the main python script is now a class derived from AnalysisStage

@ipouplana ipouplana requested a review from apuigferrat May 18, 2018 09:06
@philbucher
Copy link
Member

Nice addition @ipouplana

Note that I am abt to do some improvements to the AnalysisStage to further converge things in the BaseClass
I will do this by the beginning of next week latest

@ipouplana
Copy link
Member Author

Ok @philbucher, then maybe it is better that I wait to your improvements before merging this PR

@philbucher
Copy link
Member

@ipouplana if you merge the master then I can properly review this
Currently it shows some "old" changes

@ipouplana
Copy link
Member Author

Thanks @philbucher .

Yes, I still need to merge the master branch into this one and adapt some methods... I'll try to do it this weekend, but I'm not sure if I'll have time... When I am done I will tell you so that you can review this PR.

Regards

@ipouplana
Copy link
Member Author

I'll close this PR and delete the branch because there are some strange changes in the tetgen module that I don't want to merge...
I just created another branch with my actual changes (feature-poro-analysis) and when I finish the work on that branch I'll open a new PR and let you know @philbucher

@ipouplana ipouplana closed this Jun 18, 2018
@ipouplana ipouplana deleted the feature-poro-main-python-class branch June 18, 2018 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants