-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poromechanics main python script rewritten as a class #2121
Conversation
Nice addition @ipouplana Note that I am abt to do some improvements to the AnalysisStage to further converge things in the BaseClass |
Ok @philbucher, then maybe it is better that I wait to your improvements before merging this PR |
@ipouplana if you merge the master then I can properly review this |
Thanks @philbucher . Yes, I still need to merge the master branch into this one and adapt some methods... I'll try to do it this weekend, but I'm not sure if I'll have time... When I am done I will tell you so that you can review this PR. Regards |
I'll close this PR and delete the branch because there are some strange changes in the tetgen module that I don't want to merge... |
Essentially, the main python script is now a class derived from AnalysisStage