Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecating WorkingSpaceDimension in Condition / Element #2997

Merged
merged 1 commit into from
Oct 19, 2018
Merged

deprecating WorkingSpaceDimension in Condition / Element #2997

merged 1 commit into from
Oct 19, 2018

Conversation

philbucher
Copy link
Member

as suggested by @jcotela this should be discussed in a separate PR

I think this method is not really necessary since the Geometry can directly be asked

@philbucher philbucher requested a review from a team October 5, 2018 14:59
RiccardoRossi
RiccardoRossi reviewed Oct 6, 2018
View reviewed changes
Copy link
Member

@RiccardoRossi RiccardoRossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for this change. i am waiting to approve to see if there is anyone against

@philbucher
Copy link
Member Author

ping

@philbucher philbucher merged commit 288e555 into master Oct 19, 2018
@philbucher philbucher deleted the core/deprecate-workingspacedimension branch October 19, 2018 16:15
@philbucher philbucher mentioned this pull request Nov 5, 2018
Closed
@marandra marandra mentioned this pull request Nov 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RiccardoRossi RiccardoRossi RiccardoRossi approved these changes

Assignees

@jcotela jcotela

@philbucher philbucher

Labels
API Breaker Cleanup Deprecated Kratos Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philbucher @RiccardoRossi @jcotela