Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Poromechanics] Fixing fracture propagation utility and updating to current input standard #3777

Merged
merged 15 commits into from
Jan 9, 2019

Conversation

ipouplana
Copy link
Member

This fixes the outdated files of PR #2360. Other minor cleanup changes are included.
Tests have also been updated and run flawlessly.

//Triangle_2d_3
//GI_GAUSS_2

rExtrapolationMatrix(0,0) = 1.6666666666666666421; rExtrapolationMatrix(0,1) = -0.33333333333333334443; rExtrapolationMatrix(0,2) = -0.33333333333333334443;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should these constants be 5/3 and 1/3?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll fix it

miguelmaso
miguelmaso previously approved these changes Jan 9, 2019
Copy link
Contributor

@miguelmaso miguelmaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

Copy link
Contributor

@miguelmaso miguelmaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ipouplana ipouplana merged commit e753a73 into master Jan 9, 2019
@ipouplana ipouplana deleted the poro/fix-model-fracture branch January 9, 2019 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants