[DEM]Changing some names according to the comments by Riccardo #3832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maceligueta
reviewed
Jan 15, 2019
| @@ -501,7 +501,7 @@ def SetInitialNodalValues(self): | |||
| def InitializeTimeStep(self): | |||
| pass | |||
|
|
|||
| def BeforeSolveOperations(self, time): | |||
| def _BeforeSolveOperations(self, time): | |||
There was a problem hiding this comment.
I think we could leave the old method calling the new one plus printing a big warning on screen (with expiration date), in case someone is still using it from private applications. After some time we completely remove the old version. This is what we are doing in the Kratos core for every api breaker. What do you think?
There was a problem hiding this comment.
I suppose we dont't need to ensure backward compatibility with other methods
There was a problem hiding this comment.
I would follow the same process with all methods that get deprecated. As systematically as possible.
maceligueta
previously approved these changes
Jan 15, 2019
miguelmaso
approved these changes
Jan 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing names as promised