Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Bring over the KryptonCommandLinkButtons #1187

Closed
PWagner1 opened this issue Nov 20, 2023 · 6 comments
Closed

[Feature Request]: Bring over the KryptonCommandLinkButtons #1187

PWagner1 opened this issue Nov 20, 2023 · 6 comments
Labels
answered This question has been adequately answered. completed This issue has been completed. enhancement New feature or request new feature A new feature has been requested. suggestion A suggestion has been requested.
Milestone

Comments

@PWagner1
Copy link
Contributor

Is it time to bring over the KryptonCommandLinkButtons from the Extended Toolkit?

@PWagner1 PWagner1 added enhancement New feature or request new feature A new feature has been requested. suggestion A suggestion has been requested. labels Nov 20, 2023
@Smurf-IV Smurf-IV added the answered This question has been adequately answered. label Nov 21, 2023
@PWagner1 PWagner1 self-assigned this Dec 1, 2023
@PWagner1 PWagner1 added the in progress A fix for this issue is in the works. label Dec 1, 2023
@PWagner1 PWagner1 added this to the Version 90 milestone Dec 1, 2023
PWagner1 added a commit that referenced this issue Dec 1, 2023
Smurf-IV added a commit that referenced this issue Dec 2, 2023
@PWagner1 PWagner1 removed their assignment Dec 2, 2023
@PWagner1 PWagner1 added completed This issue has been completed. and removed in progress A fix for this issue is in the works. labels Dec 2, 2023
@PWagner1 PWagner1 closed this as completed Dec 2, 2023
@Smurf-IV
Copy link
Member

Smurf-IV commented Dec 2, 2023

Please re-open this, so that the "Class" is actually called KryptonCommandLinkButton please ?

@PWagner1 PWagner1 reopened this Dec 2, 2023
@PWagner1
Copy link
Contributor Author

PWagner1 commented Dec 2, 2023

Please re-open this, so that the "Class" is actually called KryptonCommandLinkButton please ?

@Smurf-IV There were 2 types, what should the second one be named as? Currently it's KryptonAlternateCommandLinkButton & the second one is KryptonCommandLinkButton.

@Smurf-IV
Copy link
Member

Smurf-IV commented Dec 2, 2023

I thought only one of them was actually worth using in the Ext kit.
Does the demo use both ?

@PWagner1
Copy link
Contributor Author

PWagner1 commented Dec 2, 2023

I thought only one of them was actually worth using in the Ext kit. Does the demo use both ?

@Smurf-IV Yes, the one which looks like a normal KButton is the KryptonAlternateCommandLinkButton and vice-versa. I can switch the names around?

@Smurf-IV
Copy link
Member

Smurf-IV commented Dec 2, 2023

I think it should replace the one that does not do stuff in the demo.
i.e. the one that works should have the expected name.

@Smurf-IV Smurf-IV removed the completed This issue has been completed. label Dec 2, 2023
@PWagner1 PWagner1 self-assigned this Dec 2, 2023
@PWagner1 PWagner1 added the in progress A fix for this issue is in the works. label Dec 2, 2023
@PWagner1
Copy link
Contributor Author

PWagner1 commented Dec 2, 2023

I think it should replace the one that does not do stuff in the demo. i.e. the one that works should have the expected name.

I've 'hidden' the KryptonAlternateCommandLinkButton version, so it can be revisited at a later date if needed.

@PWagner1 PWagner1 removed their assignment Dec 3, 2023
@PWagner1 PWagner1 added completed This issue has been completed. and removed in progress A fix for this issue is in the works. labels Dec 3, 2023
@PWagner1 PWagner1 closed this as completed Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered This question has been adequately answered. completed This issue has been completed. enhancement New feature or request new feature A new feature has been requested. suggestion A suggestion has been requested.
Projects
None yet
Development

No branches or pull requests

2 participants