Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Remove AllowFormIntegrate for Krypton Ribbons #1269

Closed
PWagner1 opened this issue Jan 5, 2024 · 9 comments
Closed

[Feature Request]: Remove AllowFormIntegrate for Krypton Ribbons #1269

PWagner1 opened this issue Jan 5, 2024 · 9 comments
Labels
answered This question has been adequately answered. area:ribbon All issues to do with the ribbon. completed This issue has been completed. enhancement New feature or request suggestion A suggestion has been requested. version:90 All things to do with V90.
Milestone
Version 95

Comments

@PWagner1
Copy link
Contributor

PWagner1 commented Jan 5, 2024

As per discussion in #1249, AllowFormIntegrate should be removed as it's a legacy feature that does not work well on modern versions of Windows.
@PWagner1 PWagner1 added enhancement New feature or request new feature A new feature has been requested. suggestion A suggestion has been requested. in progress A fix for this issue is in the works. area:ribbon All issues to do with the ribbon. labels Jan 5, 2024
@PWagner1 PWagner1 added this to the Version 90 milestone Jan 5, 2024
@PWagner1 PWagner1 self-assigned this Jan 5, 2024
@PWagner1
Copy link
Contributor Author

PWagner1 commented Jan 6, 2024

@Smurf-IV Whilst investigating I noticed that this feature is deeply entrenched with KForm composition code that also needs to be removed. Should I proceed,, as it would mean cutting off Win 7, 8 & 8.1 features?

@Smurf-IV
Copy link
Member

Smurf-IV commented Jan 6, 2024

mean cutting off Win 7, 8 & 8.1 features

Please expand in this ?

@Smurf-IV Smurf-IV added the under investigation This bug/issue is currently under investigation. label Jan 6, 2024
@PWagner1
Copy link
Contributor Author

PWagner1 commented Jan 6, 2024

mean cutting off Win 7, 8 & 8.1 features

Please expand in this ?

When a ribbon app is running on Win 7, the aero glass will extend into the chrome. If we remove the composition code, it'll remove this feature

image

Suggestion, turn AllowFormIntegrate on by default, or to make it a Win 7 feature only, hiding it in the designer

@Smurf-IV
Copy link
Member

Smurf-IV commented Jan 6, 2024

AllowFormIntegrate on by default

That was my expectation, in that

  • Where-ever some code was checking for it, then it would just be true, i.e. no check just do it.
  • Then this would lead to the composite code being removed as well.

hiding it in the designer

No value to hide, as it does not exist.

@PWagner1 PWagner1 removed their assignment Jan 6, 2024
@PWagner1
Copy link
Contributor Author

PWagner1 commented Jan 6, 2024

Fancy taking a shot at it? I may be over thinking it, as I thought _allowFormIntegrate = Environment.OSVersion.Version.Major >= 6 || Environment.OSVersion.Version.Major < 10; was meant to do this, or have OS version checking in the code?

@Smurf-IV Smurf-IV self-assigned this Jan 7, 2024
@Smurf-IV
Copy link
Member

Smurf-IV commented Jan 7, 2024

@Wagnerp Win10 does have transparency for some apps
See the settings side bar:
image

Is the same sort of thing still in Win 11 ?

@PWagner1
Copy link
Contributor Author

PWagner1 commented Jan 7, 2024

@Smurf-IV Yes, in Win 10 it's called Fluent UI, in 11 it's called Mica

image

image

@Smurf-IV Smurf-IV mentioned this issue Jan 7, 2024
Open
@Smurf-IV
Copy link
Member

@Wagnerp thoughts ?
image

Bottom is running on Win 10

PR coming soon - just doing some more testing

@PWagner1
Copy link
Contributor Author

@Wagnerp thoughts ? image

Bottom is running on Win 10

PR coming soon - just doing some more testing

@Smurf-IV Might be worth asking for feedback when the Jan canary build is released?

Smurf-IV added a commit that referenced this issue Jan 14, 2024
@Smurf-IV
- Remove AllowFormIntegrate to give consistent experience on all su…
e750bc7 
…pported OS's

- This led to the removal of the internal  `ApplyComposition` and related code
- Sort out a few nullables that ReSharper removed - Do'h

#1269
@Smurf-IV Smurf-IV mentioned this issue Jan 14, 2024
Merged
Smurf-IV added a commit to Krypton-Suite/Standard-Toolkit-Demos that referenced this issue Jan 14, 2024
@Smurf-IV
- Fix fallout from
69c7140 
Krypton-Suite/Standard-Toolkit#1269
@Smurf-IV Smurf-IV mentioned this issue Jan 14, 2024
Merged
Smurf-IV added a commit to Krypton-Suite/Theme-Palettes that referenced this issue Jan 14, 2024
@Smurf-IV
- Fix fallout from
bf45c09 
#Krypton-Suite/Standard-Toolkit#1269
@Smurf-IV Smurf-IV mentioned this issue Jan 14, 2024
Merged
@Smurf-IV Smurf-IV removed their assignment Jan 14, 2024
@Smurf-IV Smurf-IV removed new feature A new feature has been requested. under investigation This bug/issue is currently under investigation. in progress A fix for this issue is in the works. labels Jan 14, 2024
@Smurf-IV Smurf-IV added answered This question has been adequately answered. completed This issue has been completed. labels Jan 14, 2024
@Smurf-IV Smurf-IV self-assigned this Jan 28, 2024
@Smurf-IV Smurf-IV added the in progress A fix for this issue is in the works. label Jan 28, 2024
@Smurf-IV Smurf-IV removed their assignment Jan 28, 2024
@Smurf-IV Smurf-IV removed the in progress A fix for this issue is in the works. label Jan 28, 2024
@Smurf-IV Smurf-IV mentioned this issue Jan 28, 2024
Closed
@PWagner1 PWagner1 added the version:90 All things to do with V90. label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
answered This question has been adequately answered. area:ribbon All issues to do with the ribbon. completed This issue has been completed. enhancement New feature or request suggestion A suggestion has been requested. version:90 All things to do with V90.
Projects
None yet
Milestone
Version 95
2 participants
@PWagner1 @Smurf-IV