Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Font being used by "Professional" theme is pants ! #1302

Closed
Smurf-IV opened this issue Jan 28, 2024 · 13 comments
Closed

[Bug]: Font being used by "Professional" theme is pants ! #1302

Smurf-IV opened this issue Jan 28, 2024 · 13 comments
Labels
area:themes All things to do with themes. bug Something isn't working completed This issue has been completed. regression Something was working in a previous release, but isn't working now. version:85-lts All things to do with V85 LTS. version:90 All things to do with V90.
Milestone

Comments

@Smurf-IV
Copy link
Member

Smurf-IV commented Jan 28, 2024

Using Todays Alpha and the Ribbon example.
The Font used by the "Professional" themes is very bad:

image

Compared this with the Office 2007 theme font:
image

@Smurf-IV Smurf-IV added bug Something isn't working area:themes All things to do with themes. regression Something was working in a previous release, but isn't working now. labels Jan 28, 2024
@PWagner1
Copy link
Contributor

Maybe use Arial as the default for professional, or is this something else?

@tobitege
Copy link

Office 2007 default font was Calibri

@giduac
Copy link
Contributor

giduac commented Jun 18, 2024

Hi @Wagnerp,

It looks like this one has been tackled?

@PWagner1
Copy link
Contributor

Hi @Wagnerp,

It looks like this one has been tackled?

@giduac

Append to v90 changelog list.

@PWagner1 PWagner1 added this to the Version 90 milestone Jun 20, 2024
@PWagner1 PWagner1 added the version:90 All things to do with V90. label Jun 21, 2024
@Smurf-IV
Copy link
Member Author

Hi @Wagnerp,

It looks like this one has been tackled?

No, Still the same:
image

@Smurf-IV
Copy link
Member Author

Note: 2007 Professional Blue looks okay:
image

@Smurf-IV Smurf-IV added the version:85-lts All things to do with V85 LTS. label Jun 22, 2024
@PWagner1
Copy link
Contributor

@Smurf-IV Is it something to do with the text rendering?

@Smurf-IV
Copy link
Member Author

Smurf-IV commented Jun 22, 2024

@Smurf-IV Is it something to do with the text rendering?

But that should be affected regardless of the font.

And why in some apps does it not do it ?
e.g.:
https://github.com/giduac/Standard-Toolkit-Demos/tree/ribbon-controls-themes-test
Demo Solution: Krypton Ribbon Examples 2022 (Debug) - Nuget
Project: Application Menu 2022
TK: Latest Nightly 169

@PWagner1
Copy link
Contributor

@Smurf-IV Is it something to do with the text rendering?

But that should be affected regardless of the font.

And why in some apps does it not do it ? e.g.: https://github.com/giduac/Standard-Toolkit-Demos/tree/ribbon-controls-themes-test Demo Solution: Krypton Ribbon Examples 2022 (Debug) - Nuget Project: Application Menu 2022 TK: Latest Nightly 169

Is it something in the app manifest?

@Smurf-IV
Copy link
Member Author

Is it something in the app manifest?

Nope, they are the same, as is the program.cs.
No clues in the designer file either...

@Smurf-IV Smurf-IV self-assigned this Jun 22, 2024
@Smurf-IV Smurf-IV added the under investigation This bug/issue is currently under investigation. label Jun 22, 2024
@Smurf-IV
Copy link
Member Author

Found the "Problem". It will be a breaking change.
image

@PWagner1
Copy link
Contributor

Found the "Problem". It will be a breaking change. image

What was it?

@Smurf-IV
Copy link
Member Author

What was it?

Usage redirect for this:
image
https://learn.microsoft.com/en-us/dotnet/api/system.drawing.text.textrenderinghint?view=net-8.0

Which is "Not" appropriate for a theming suite like this !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:themes All things to do with themes. bug Something isn't working completed This issue has been completed. regression Something was working in a previous release, but isn't working now. version:85-lts All things to do with V85 LTS. version:90 All things to do with V90.
Projects
None yet
Development

No branches or pull requests

4 participants