Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask to save new credentials in apps and browsers #524

Closed
matesurano opened this issue Apr 16, 2020 · 10 comments
Closed

Ask to save new credentials in apps and browsers #524

matesurano opened this issue Apr 16, 2020 · 10 comments

Comments

@matesurano
Copy link

matesurano commented Apr 16, 2020

Describe the solution you'd like
Every time any new credentials (username/password) is entered in apps and browsers, keepass dx should ask(if already not in database)if we want to save it.

Most of the other password managers like bitwarden, Samsung pass, dashlane do this.
App Version : 2.5RC1
Android version 9(pie)
Device: Samsung Galaxy s8.

@J-Jamet J-Jamet added this to the Autofill milestone Apr 16, 2020
@J-Jamet
Copy link
Member

J-Jamet commented Apr 16, 2020

Are you talking about registering a new account or providing credentials once the account is created?

@matesurano
Copy link
Author

Example: i go to Yahoo login page and type in username and password (no autofill prompt cause credentials are not saved in keepass dx). After login in or say in the next step KeePassDX asks me if i want to save the credentials in keepass dx(yes/no). Similarly it can be (i am not sure) during(or after) a new account creation also. Many password managers do this e.g. Dashlane.

@J-Jamet
Copy link
Member

J-Jamet commented Apr 16, 2020

Okay, this functionality will be done in a second step. I must already manage the identifiers which are known. But once this code is completed, I can study how the registration of new items works.

@matesurano
Copy link
Author

Thanks. 🙏

@J-Jamet
Copy link
Member

J-Jamet commented Jul 10, 2020

I studied a possible way and I have to make a new workflow which does not conflict with read only. I intend to make a button to switch on the fly between "selection mode" and "recording mode".

@jj10133
Copy link

jj10133 commented Oct 7, 2020

@J-Jamet I'm new to this project is there a documentation?? so I could follow up and contribute to the project

@J-Jamet
Copy link
Member

J-Jamet commented Oct 7, 2020

There is no technical documentation at the moment. You have to look at the sources, if you don't understand something you can ask. Otherwise there is the github wiki for global information.

As the current project indicates, I am working on this functionality. Git branch : Autofill_Save

@J-Jamet
Copy link
Member

J-Jamet commented Oct 14, 2020

For the feature advancement:

I still have to save new entries in selection mode. But the registration from the autofill is ready.
For registering a WebDomain in an entry:

  • if the URL field is empty, it will be filled with the URI: [scheme]://[webdomain] provided by the browser.

  • If the URL field is not empty, a new custom WebDomain field will be created so as not to conflict with the already existing URL (or WebDomain[n] with n an increment to allow multiple autofill with the same entry).

For the application Id, it will be saved in a custom ApplicationId field (or ApplicationId[n] with n an increment).
Note that the customized fields are only available for KDBX databases (not KDB bases) therefore registration will be limited for the old databases.

It will also be necessary to manage the conflicts of the read-only mode but I am rather happy with the progress.

@strongbox-mark
Copy link

Hi @J-Jamet - Strongbox (an iOS KeePass client) dev here... just got notification of this from @hokonch...

We (KeePassXC, myself and a few others) have been trying to sort of standardize a little the extensions to the KeePass format across clients so that everyone's databases work basically the same on different clients.

One of the changes is "Alternative URLs". I wonder if this applies here? I might be misunderstanding the context here but if KeePassDX is looking for a method to store Alternative/Additional URLs for an entry it would be awesome if we could all use the same format/scheme.

Is this something you think would work for KeePassDX?

Kudos on the app by the way! Would be great to have you on board at keepassxreboot/keepassxc#4317

@J-Jamet
Copy link
Member

J-Jamet commented Nov 16, 2020

if KeePassDX is looking for a method to store Alternative/Additional URLs for an entry it would be awesome if we could all use the same format/scheme.

Yes of course, harmonization is a good thing. I had to change the name of the new URL fields because there was the prefix KP2A_ if the database warned of KeePass2Android, which is not a good generic nomenclature, but a new harmonized name would be good.

Is this something you think would work for KeePassDX?

I linkify links on the fly when they're already there, and I search globally, so that's okay with that.
There might be a link duplication for newly registered items, but that's not a huge bug.

Kudos on the app by the way! Would be great to have you on board at keepassxreboot/keepassxc#4317

Thanks for the link, I'll look at the conversation in more detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants