Update target door state fixes

KyleBoyer · Jul 15, 2024 · 9449b3e · 9449b3e
1 parent e274b02
commit 9449b3e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -2,7 +2,7 @@
   "private": false,
   "displayName": "Konnected BlaQ",
   "name": "homebridge-blaq",
-  "version": "0.2.14",
+  "version": "0.2.15",
   "description": "Control and view your garage door(s) remotely with real-time updates using Konnected's BlaQ hardware",
   "license": "Apache-2.0",
   "type": "module",

diff --git a/src/accessory/garage-door.ts b/src/accessory/garage-door.ts
@@ -240,10 +240,10 @@ export class BlaQGarageDoorAccessory implements BaseBlaQAccessory {
   }
 
   getTargetDoorState(): CharacteristicValue {
-    if(this.currentOperation === 'OPENING' || (this.targetPosition !== undefined && this.targetPosition > 0)){
-      return this.platform.characteristic.TargetDoorState.OPEN;
-    } else if(this.currentOperation === 'CLOSING' || this.preClosing || (this.targetPosition !== undefined && this.targetPosition <= 0)){
+    if(this.currentOperation === 'CLOSING' || this.preClosing || (this.targetPosition !== undefined && this.targetPosition <= 0)){
       return this.platform.characteristic.TargetDoorState.CLOSED;
+    } else if(this.currentOperation === 'OPENING' || (this.targetPosition !== undefined && this.targetPosition > 0)){
+      return this.platform.characteristic.TargetDoorState.OPEN;
     } else if(this.currentOperation === 'IDLE'){
       if(this.state === 'CLOSED'){
         return this.platform.characteristic.TargetDoorState.CLOSED;
@@ -406,7 +406,7 @@ export class BlaQGarageDoorAccessory implements BaseBlaQAccessory {
         this.setPreClosing(true);
         setTimeout(() => {
           this.setPreClosing(false);
-        }, warningDuration);
+        }, warningDuration + 100); // add 100ms for closing state to happen right after
       }
     } catch(e) {
       this.logger.error('Log parsing error:', e);