Skip to content

Commit

Permalink
More debug logging around target/current door state
Browse files Browse the repository at this point in the history
  • Loading branch information
KyleBoyer committed Aug 2, 2024
1 parent db91c54 commit cd9fe82
Show file tree
Hide file tree
Showing 3 changed files with 30 additions and 3 deletions.
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"private": false,
"displayName": "Konnected BlaQ",
"name": "homebridge-blaq",
"version": "0.2.25",
"version": "0.2.26",
"description": "Control and view your garage door(s) remotely with real-time updates using Konnected's BlaQ hardware",
"license": "Apache-2.0",
"type": "module",
Expand Down
27 changes: 27 additions & 0 deletions src/accessory/garage-door.ts
Original file line number Diff line number Diff line change
Expand Up @@ -128,14 +128,30 @@ export class BlaQGarageDoorAccessory extends BaseBlaQAccessory {
if(this.preClosing || this.currentOperation === 'CLOSING' || (
this.position !== undefined && this.targetPosition !== undefined && this.targetPosition < this.position
)){
let closingReason = 'current operation is CLOSING';
if(this.preClosing){
closingReason = 'the pre-close warning is active';
} else if(this.position !== undefined && this.targetPosition !== undefined && this.targetPosition < this.position){
closingReason = `the target position (${this.targetPosition}) is less than the current position (${this.position})`;
}
this.logger.debug(`Returning current state CLOSING because: ${closingReason}`);
return this.platform.characteristic.CurrentDoorState.CLOSING;
} else if(this.currentOperation === 'OPENING' || (
this.position !== undefined && this.targetPosition !== undefined && this.targetPosition > this.position
)){
const openingReason =
this.currentOperation === 'OPENING' ?
'current operation is OPENING' :
`the target position (${this.targetPosition}) is greater than the current position (${this.position})`;
this.logger.debug(`Returning current state OPENING because: ${openingReason}`);
return this.platform.characteristic.CurrentDoorState.OPENING;
} else if (this.state === 'OPEN' || (this.position !== undefined && this.position > 0)) {
const openReason = this.state === 'OPEN' ? 'the current state is OPEN' : 'the current position is greater than zero';
this.logger.debug(`Returning current state OPENING because: ${openReason}`);
return this.platform.characteristic.CurrentDoorState.OPEN;
} else if (this.state === 'CLOSED' || (this.position !== undefined && this.position <= 0)) {
const closedReason = this.state === 'CLOSED' ? 'the current state is CLOSED' : 'the current position is less than or equal to zero';
this.logger.debug(`Returning current state OPENING because: ${closedReason}`);
return this.platform.characteristic.CurrentDoorState.CLOSED;
}
throw new Error(`Invalid door state: ${this.state}`);
Expand Down Expand Up @@ -220,13 +236,24 @@ export class BlaQGarageDoorAccessory extends BaseBlaQAccessory {

getTargetDoorState(): CharacteristicValue {
if(this.currentOperation === 'CLOSING' || this.preClosing || (this.targetPosition !== undefined && this.targetPosition <= 0)){
let closedReason = 'current operation is CLOSING';
if(this.preClosing){
closedReason = 'the pre-close warning is active';
}else if(this.targetPosition !== undefined && this.targetPosition <= 0){
closedReason = 'target position is less than or equal to zero';
}
this.logger.debug(`Returning target state CLOSED because: ${closedReason}`);
return this.platform.characteristic.TargetDoorState.CLOSED;
} else if(this.currentOperation === 'OPENING' || (this.targetPosition !== undefined && this.targetPosition > 0)){
const openReason = this.currentOperation === 'OPENING' ? 'current operation is OPENING' : 'target position is greater than zero';
this.logger.debug(`Returning target state OPEN because: ${openReason}`);
return this.platform.characteristic.TargetDoorState.OPEN;
} else if(this.currentOperation === 'IDLE'){
if(this.state === 'CLOSED'){
this.logger.debug('Returning target state CLOSED because: current operation is IDLE and current state is CLOSED');
return this.platform.characteristic.TargetDoorState.CLOSED;
}else if(this.state === 'OPEN'){
this.logger.debug('Returning target state CLOSED because: current operation is IDLE and current state is OPEN');
return this.platform.characteristic.TargetDoorState.OPEN;
}
}
Expand Down

0 comments on commit cd9fe82

Please sign in to comment.