Count missing values as reads in PerformanceMetricsStorageAdapter

LDeakin · Oct 31, 2024 · 68b9b29 · 68b9b29
1 parent b648c46
commit 68b9b29
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/zarrs_storage/CHANGELOG.md b/zarrs_storage/CHANGELOG.md
@@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
  - **Breaking**: Bump MSRV to 1.77 (21 March, 2024)
  - **Breaking**: Rename `StoreKeyStartValue` to `StoreKeyOffsetValue`
    - Adds `offset` method and removes `start` and `end`
+ - Count missing values as reads in `PerformanceMetricsStorageAdapter`
 
 ### Removed
  - **Breaking**: Remove `ByteRange::offset()`

diff --git a/zarrs_storage/src/storage_adapter/performance_metrics.rs b/zarrs_storage/src/storage_adapter/performance_metrics.rs
@@ -85,8 +85,8 @@ impl<TStorage: ?Sized + ReadableStorageTraits> ReadableStorageTraits
         if let Some(values) = &values {
             let bytes_read = values.iter().map(Bytes::len).sum();
             self.bytes_read.fetch_add(bytes_read, Ordering::Relaxed);
-            self.reads.fetch_add(byte_ranges.len(), Ordering::Relaxed);
         }
+        self.reads.fetch_add(byte_ranges.len(), Ordering::Relaxed);
         Ok(values)
     }