Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: rename binary data type to bytes #118

Merged
merged 1 commit into from
Jan 1, 2025
Merged

Conversation

LDeakin
Copy link
Owner

@LDeakin LDeakin commented Jan 1, 2025

closes #114

Copy link

codecov bot commented Jan 1, 2025

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Project coverage is 81.68%. Comparing base (6a8baed) to head (6f99887).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
zarrs/src/array/data_type.rs 60.00% 2 Missing ⚠️
zarrs_metadata/src/v3/array/data_type.rs 33.33% 2 Missing ⚠️
zarrs/src/array/codec/array_to_bytes/bytes.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #118   +/-   ##
=======================================
  Coverage   81.68%   81.68%           
=======================================
  Files         166      166           
  Lines       23756    23756           
=======================================
+ Hits        19405    19406    +1     
+ Misses       4351     4350    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LDeakin LDeakin merged commit 698fb83 into main Jan 1, 2025
22 checks passed
@LDeakin LDeakin deleted the binary_to_bytes branch January 1, 2025 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename DataType::Binary to DataType::Bytes
1 participant