[BUG]: Komorebi Crashes When Window Opens on 'Wrong Workspace' #1212
Labels
bug
Something isn't working
Comments
|
This is an odd one, I use the workspace rules quite regularly and I haven't seen this before. Can you run |
|
I tried recreating it. i found it a bit odd too. assuming its quite common to be using workspace rules and i dont see any issues being created for it ive been having this problem since the previous release komorebi.hangs.on.workspace.rules.part.2.-.Made.with.Clipchamp.mp4 |
|
Looks like there has been a deadlock introduced somewhere, I think this is enough info to help me start digging 👀 |
|
Found it |
|
Should be fixed in the next |
|
damn. quick work bro. fixed in the new build 👍 |
LGUG2Z
added a commit
that referenced
this issue
Jan 5, 2025
This commit adds mutex lock scoping in WindowManager::enforce_workspace_rule to avoid a deadlock when should_update_focused_workspace evaluates to true. fix #1212
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
If the workspace rules define that a window should be opened on
workspace 2and if you were to open it on any other workspace then komorebi transfers the window to the correct workspace but subsequently immediately crashes.komorebi.workspace.rules.crash.-.Made.with.Clipchamp.mp4
Version Information
OS Name: Microsoft Windows 11 Home
OS Version: 10.0.22631 N/A Build 22631
komorebic 0.1.32
tag:v0.1.32
commit_hash:4b9d8114
build_time:2025-01-01 19:37:02 +00:00
build_env:rustc 1.83.0 (90b35a623 2024-11-26),stable-x86_64-pc-windows-msvc
Komorebi Configuration
{ "$schema": "https://raw.githubusercontent.com/LGUG2Z/komorebi/v0.1.29/schema.bar.json", "monitor": { "index": 0, "work_area_offset": { "left": 0, "top": 30, "right": 0, "bottom": 30 } }, "position": { "start": { "x": 0, "y": -10 }, "end": { "x": 1920, "y": 45 } }, "font_size": 11, "font_family": "Cascadia Code", "theme": { "palette": "Base16", "name": "Chalk", "accent": "Base0F" }, "left_widgets": [ { "Komorebi": { "workspaces": { "enable": true, "hide_empty_workspaces": true }, "layout": { "enable": true }, "focused_window": { "enable": false, "show_icon": false } } } ], "right_widgets": [ { "Media": { "enable": true } }, { "Storage": { "enable": false } }, { "Memory": { "enable": true } }, { "Network": { "enable": false, "data_refresh_interval": 1, "show_total_data_transmitted": false, "show_network_activity": false } }, { "Date": { "enable": true, "format": "DayDateMonthYear" } }, { "Time": { "enable": true, "format": { "Custom": "%H:%M %p" } } }, { "Battery": { "enable": true, "data_refresh_interval": 60 } } ] } { "$schema": "https://raw.githubusercontent.com/LGUG2Z/komorebi/v0.1.28/schema.json", "app_specific_configuration_path": "$Env:USERPROFILE/applications.json", "window_hiding_behaviour": "Cloak", "cross_monitor_move_behaviour": "Insert", "default_workspace_padding": 1, "default_container_padding": 1, "transparency": false, "border": true, "border_width": 0, "border_style": "System", "border_implementation": "Windows", "border_colours": { "single": "#a6856e", "stack": "#a6856e", "monocle": "#fc585e", "unfocused": "#000000" }, "stackbar": { "label": "Title", "height": 32, "mode": "OnStack", "tabs": { "width": 220, "focused_text": "#a6856e", "unfocused_text": "#383838", "background": "#000000", "font_size": 28, "font_family": "Consolas" } }, "monitors": [ { "workspaces": [ { "name": "1 Code", "layout": "BSP", "workspace_rules": [ { "id": "idea64.exe", "kind": "Exe" }, { "id": "studio64.exe", "kind": "Exe" } ] }, { "name": "2 Notes", "layout": "BSP", "workspace_rules": [ { "id": "Obsidian.exe", "kind": "Exe" } ] }, { "name": "3 Web", "layout": "BSP" }, { "name": "4 Comm", "layout": "BSP", "workspace_rules": [ { "id": "WhatsApp Beta", "kind": "Title", "matching_strategy": "Equals" } ] }, { "name": "5 AI", "layout": "BSP", "initial_workspace_rules": [ { "id": "ChatGPT App", "kind": "Title", "matching_strategy": "StartsWith" }, { "id": "Perplexity App", "kind": "Title", "matching_strategy": "StartsWith" }, { "id": "Claude", "kind": "Title", "matching_strategy": "StartsWith" } ] }, { "name": "6 Media", "layout": "BSP" }, { "name": "7 Social", "layout": "BSP" }, { "name": "8 Flow", "layout": "BSP" }, { "name": "9 FLow", "layout": "BSP" }, { "name": "0 Swap", "layout": "BSP", "workspace_rules": [ { "id": "edit_komorebi", "kind": "Title", "matching_strategy": "Contains" } ] } ] } ], "ignore_rules": [ { "id": "Voice call - WhatsApp Beta", "kind": "Title", "matching_strategy": "Equals" } ] }Hotkey Configuration
.shell powershell
Reload whkd configuration
alt + o : taskkill /f /im whkd.exe && start /b whkd # if shell is cmd
alt + o : taskkill /f /im whkd.exe; Start-Process whkd -WindowStyle hidden # if shell is pwsh / powershell
alt + shift + o : komorebic reload-configuration
alt + shift + b : Stop-Process -name komorebi-bar; Start-Process komorebi-bar -windowstyle hidden
App shortcuts - these require shell to be pwsh / powershell
The apps will be focused if open, or launched if not open
alt + f : if ($wshell.AppActivate('Firefox') -eq $False) { start firefox }
alt + b : if ($wshell.AppActivate('Chrome') -eq $False) { start chrome }
alt + q : komorebic close
alt + m : komorebic minimize
Focus windows
alt + h : komorebic focus left
alt + j : komorebic focus down
alt + k : komorebic focus up
alt + l : komorebic focus right
alt + ctrl + oem_4 : komorebic cycle-focus previous # oem_4 is [
alt + ctrl + oem_6 : komorebic cycle-focus next # oem_6 is ]
Move windows
alt + shift + h : komorebic move left
alt + shift + j : komorebic move down
alt + shift + k : komorebic move up
alt + shift + l : komorebic move right
alt + shift + return : komorebic promote
Stack windows
alt + shift + oem_4 : komorebic stack left
alt + ctrl + oem_4 : komorebic stack down
alt + ctrl + oem_6 : komorebic stack up
alt + shift + oem_6 : komorebic stack right
alt + oem_1 : komorebic unstack # oem_1 is ;
alt + oem_4 : komorebic cycle-stack previous # oem_4 is [
alt + oem_6 : komorebic cycle-stack next # oem_6 is ]
Resize
alt + oem_plus : komorebic resize-axis horizontal increase
alt + oem_minus : komorebic resize-axis horizontal decrease
alt + shift + oem_plus : komorebic resize-axis vertical increase
alt + shift + oem_minus : komorebic resize-axis vertical decrease
Manipulate windows
alt + shift + d : komorebic toggle-float
alt + d : komorebic toggle-monocle
Window manager options
alt + shift + r : komorebic retile
alt + shift + p : komorebic toggle-pause
alt + shift + m : komorebic manage
Layouts
alt + x : komorebic flip-layout horizontal
alt + y : komorebic flip-layout vertical
Workspaces
alt + 1 : komorebic focus-workspace 0
alt + 2 : komorebic focus-workspace 1
alt + 3 : komorebic focus-workspace 2
alt + 4 : komorebic focus-workspace 3
alt + 5 : komorebic focus-workspace 4
alt + 6 : komorebic focus-workspace 5
alt + 7 : komorebic focus-workspace 6
alt + 8 : komorebic focus-workspace 7
alt + 9 : komorebic focus-workspace 8
alt + 0 : komorebic focus-workspace 9
Move windows across workspaces
alt + shift + 1 : komorebic move-to-workspace 0
alt + shift + 2 : komorebic move-to-workspace 1
alt + shift + 3 : komorebic move-to-workspace 2
alt + shift + 4 : komorebic move-to-workspace 3
alt + shift + 5 : komorebic move-to-workspace 4
alt + shift + 6 : komorebic move-to-workspace 5
alt + shift + 7 : komorebic move-to-workspace 6
alt + shift + 8 : komorebic move-to-workspace 7
alt + shift + 9 : komorebic move-to-workspace 8
alt + shift + 0 : komorebic move-to-workspace 9
Launch Apps
ctrl + alt + c : Start-Process chrome.exe
Output of komorebic check
Looking for configuration files in C:\Users\mmsye
Found komorebi.json; this file can be passed to the start command with the --config flag
Found C:\Users\mmsye.config\whkdrc; key bindings will be loaded from here when whkd is started, and you can start it automatically using the --whkd flag
The text was updated successfully, but these errors were encountered: