-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: Norton 360's Data Protector blocked a suspicious action #855
Comments
https://learn.microsoft.com/en-us/windows/win32/wer/windows-error-reporting I guess this is something at the OS level or maybe a result of installing with WinGet, because |
Now that I come to think of it, I'd installed 0.1.24 and 0.1.25 with the MSI, but 0.1.26 was probably the first I installed with winget. Therefore maybe it is something to do with that. |
Checking Event Viewer, I see the following for yesterday. It seems to be about a GDI object leak.
|
This commit ensures that HPEN and HBRUSH objects created to draw window borders are explicitly destroyed with calls to DeleteObject after EndPaint has been called. re #855
Thanks for grabbing this information! It looks like I was missing a few calls to DeleteObject before - I've added these in which should resolve the GDIObjectLeaks from the border manager at least; I'll need to take a look and see if we need to do something similar for the stackbar manager. |
This commit ensures that HPEN, HBRUSH and HFONT objects which are used to draw stackbar tabs are explicitly destroyed with calls to DeleteObject after ReleaseDC has been called. re #855
Found some in the stackbar manager too which I've addressed above ^ This doesn't really address the Norton issue (not sure there is anything we can do for overzealous AV software) - but the info in this issue has definitely helped us improve the correctness of komorebi 🎉 |
Thank you for the quick response. I think the next release will resolve it for now. If it happens again I'll know to check event viewer for more information. |
Since installing the update, I haven't seen any popups from Norton or logs in Event Viewer about leaks, so I think that this is resolved. Thank you. |
Describe the bug
Since updating from v0.1.25 to v0.1.26, I've had Norton 360's Data Protector notify me 8 times that it blocked a suspicious action by komorebic.exe. The target file path always starts with
C:\ProgramData\Microsoft\Windows\WER\
:I've tried to look for more details, but haven't managed to find any yet.
To Reproduce
Not sure
Expected behavior
Screenshots and Videos
Operating System
komorebic check
OutputAdditional context
I'm not running AHK scripts or any other software to handle any aspect of window management or manipulation
The text was updated successfully, but these errors were encountered: