feat(bar): Keyboard Widget #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, current input method was retrieved via the Language::CurrentInputMethodLanguageTag() call, which is inaccurate as it is retrieving the current input method of the bar itself, so it will only be updated when the bar is in focus. The fix is getting the TID of the currently focused window and read its input method.
|
Code looks good to me (just needs a Once you resolve these two things I think this should be good to merge! Great work! |
|
Should all be fixed now |
LGUG2Z
pushed a commit
that referenced
this pull request
Feb 8, 2025
This commit is a squashed commit containing the below commits from PR #1266, which introduces a new "Keyboard" widget, which is used to display information about the user's currently selected keyboard input language. This new widget has a data refresh interval of 1 second if not specified by the user. 721d2ef 58373cd ce27a76 fb9054a 55cc2fd 461a738 781b8d0 fa6bf6f
|
This is has been merged and will go into the next release, congratulations on shipping your first feature in this project and thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new widget for komorebi bar to display the current keyboard input method.