Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow plugins to be skipped at runtime #7691

Merged
merged 5 commits into from
Feb 18, 2025
Merged

Allow plugins to be skipped at runtime #7691

merged 5 commits into from
Feb 18, 2025

Conversation

tresf
Copy link
Member

@tresf tresf commented Feb 8, 2025

When LMMS starts up on a Linux system without Carla installed, the log shows warnings:

BEFORE:

[carla-hook.sh] Carla does not appear to be installed.  That's OK, please ignore any related library errors.
Cannot load library /home/owner/Downloads/squashfs-root/usr/lib/libcarlabase.so: (libcarla_native-plugin.so: cannot open shared object file: No such file or directory)
Cannot load library /home/owner/Downloads/squashfs-root/usr/lib/libcarlarack.so: (libcarla_native-plugin.so: cannot open shared object file: No such file or directory)
Cannot load library /home/owner/Downloads/squashfs-root/usr/lib/libcarlapatchbay.so: (libcarla_native-plugin.so: cannot open shared object file: No such file or directory)

... however, as can be observed by the logs, we already detected this problem, so we should have a way of informing LMMS to not load plugin at startup.

This PR adds a plugin filter called LMMS_EXCLUDE_PLUGINS that can be set as an environment variable to suppress this by skipping the loading of the a plugin based on name or wildcard (QRegexExpression).

AFTER:

[carla-hook.sh] Carla does not appear to be installed, we'll remove it from the plugin listing.

@tresf tresf added this to the 1.3 milestone Feb 8, 2025
Copy link
Member

@messmerd messmerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and it worked. I have some minor gripes with code style, and it's not as efficient as it could be, but it only runs once at startup so I'm not really concerned.

@messmerd
Copy link
Member

This might fix #5525 or at least work around it

@tresf
Copy link
Member Author

tresf commented Feb 13, 2025

I tested it and it worked. I have some minor gripes with code style, and it's not as efficient as it could be, but it only runs once at startup so I'm not really concerned.

Please provide any feedback that you wish, or if it's easier, please feel free to push directly to this branch.

@tresf
Copy link
Member Author

tresf commented Feb 13, 2025

it's not as efficient as it could be

I know they should be filtered as they're scanned, but I didn't want to remove the ever-so-clean files.unite.

@tresf tresf merged commit 7725d00 into LMMS:master Feb 18, 2025
10 checks passed
@tresf tresf deleted the quiet-carla branch February 18, 2025 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants