-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mute and solo buttons to instrument windows #7708
base: master
Are you sure you want to change the base?
Conversation
From the screenshot you provided, it looks like the mute and solo buttons are being merged into the same space as that of the volume knob. I'm thinking having a separate section for the mute and solo buttons (with a label like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good to me. Will test and wait for CI before approving.
Co-authored-by: Sotonye Atemie <[email protected]>
To me the knobs feel a bit crowded, almost like the pitch range lcd should be moved closer to the channel lcd, idk |
I think there was some separation already added before this PR, but since we need that space now it's probably okay to remove. |
- Change label from "M/S" to "M&S", as to not be confused with mid/side - Adjust layout to preserve space between panning and pitch bend controls
After some discussion in the Discord, the save button size and other such layout issues not directly related to the addition of these buttons will be addressed elsewhere. |
Resolves #2685 by adding mute and solo controls to instrument windows next to the volume knob.
As of 2025-02-13, this is what it looks like:
