Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mute and solo buttons to instrument windows #7708

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rubiefawn
Copy link
Contributor

Resolves #2685 by adding mute and solo controls to instrument windows next to the volume knob.

As of 2025-02-13, this is what it looks like:
screenshot-2025-02-13 15-30-30

@sakertooth
Copy link
Contributor

From the screenshot you provided, it looks like the mute and solo buttons are being merged into the same space as that of the volume knob. I'm thinking having a separate section for the mute and solo buttons (with a label like M/S) might be better.

@rubiefawn
Copy link
Contributor Author

Here's what that looks like:
image

@sakertooth
Copy link
Contributor

Here's what that looks like: image

That looks a lot better IMO!

Copy link
Contributor

@sakertooth sakertooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me. Will test and wait for CI before approving.

src/gui/instrument/InstrumentTrackWindow.cpp Outdated Show resolved Hide resolved
Co-authored-by: Sotonye Atemie <[email protected]>
@regulus79
Copy link
Contributor

To me the knobs feel a bit crowded, almost like the pitch range lcd should be moved closer to the channel lcd, idk

@sakertooth
Copy link
Contributor

sakertooth commented Feb 14, 2025

To me the knobs feel a bit crowded, almost like the pitch range lcd should be moved closer to the channel lcd, idk

I think there was some separation already added before this PR, but since we need that space now it's probably okay to remove.

@rubiefawn
Copy link
Contributor Author

rubiefawn commented Feb 14, 2025

If we're going to address the lack of real estate in this PR, I would like to move the oversized preset save button to the left of the preset name, and make it the same size as the previous/next instrument buttons.

Wait, do we really need the previous/next instrument buttons in the first place? I don't think I've ever used them, since I just click on the specific instrument I want to edit from the track view.

Here's what it could look like if the previous/next buttons were replaced by the save button (this one is a hasty photoshop job)
413423609-1df92737-76d4-4f8f-ab23-e67839dbadb7(1)

- Change label from "M/S" to "M&S", as to not be confused with mid/side
- Adjust layout to preserve space between panning and pitch bend controls
@rubiefawn
Copy link
Contributor Author

After some discussion in the Discord, the save button size and other such layout issues not directly related to the addition of these buttons will be addressed elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On/Off toggle button on instruments
3 participants