Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: add favorites and randomplay #67

Merged
merged 1 commit into from
Aug 4, 2024

Conversation

edgar-vincent
Copy link
Contributor

This adds pages for the randomplay and favorites CLI commands.

I haven't tested the commands thoroughly yet, but what I have tested is fine so far.

The HTML documentation that comes bundled with Lyrion lists both commands and tagged parameters as "tags". I kept it that way in this PR, but I wonder whether a change could be needed.

@michaelherger
Copy link
Member

Thanks a lot for this!

What kind of change would you suggest? Change in the CLI itself, or in the documentation?

@edgar-vincent
Copy link
Contributor Author

Hello @michaelherger,

My mistake, I think tagged parameters are, in fact, documented properly. I don't know where my confusion came from.

@edgar-vincent edgar-vincent marked this pull request as ready for review August 4, 2024 12:21
@michaelherger michaelherger merged commit 67ed591 into LMS-Community:main Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants