Extended onError method for returning also response object #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, sorry for the delay in responding. This is a good idea, thanks. Merging now. |
LPology
added a commit
that referenced
this pull request
Jan 19, 2014
Extended onError method for returning also response object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Happy new year! :)
Thanks for a great uploader: it's small and simple and do the stuff!
But, in my case, i have a REST JSON API, which always response me a json, and some http status code (which is not always 200/OK). So, to notify user about some server-side validation errors, i need access to response object in onError callback. You have provided this object in onComplete callback, but not in other cases. If you don't mind, i have extended onError callback, to also contain response object, if it exists, or FALSE in other cases.