-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auxtel fit pt #100
Merged
Merged
Auxtel fit pt #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debug auxtel I still need to check if its work because following detailed instructions according github one by one failed. Just wait for my next comment.
refine the prior on DCCD for auxtel
…lynom for spectrogram trace to ADR model; better handling of the masks for faster computation; 3 loops to compute ADR
Major improvements for Spectractor new version 2.3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have corrected two problems
return arr.reshape(shape).sum(-1).sum(1)
instead of
return arr.reshape(shape).mean(-1).mean(1)
I have checked the final spectrum for CCD_REBIN = 2 was at the same flux level as for CCD_REBIN =1
After a call to find_target_init in image.py I often got a crash. Most of the cases, it happens with CCD_REBIN = 2, but I think it has nothing to do with this.
When making the sub_image_subtracted little image
sub_image_subtracted = sub_image - bkgd_2D(X, Y)
we must suppress negative values like this:
SDC : very important clipping negative signal, avoiding crash later sub_image_subtracted = np.where(sub_image_subtracted<0,0,sub_image_subtracted)
Because later these values are considered as weights (to find the target center).
Since that correction, I haven't anymore crashes.
Other things added, : few control plots in debug mode and make nicer plots by changing some sizes.