Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COSMOS example notebook #42

Merged
merged 12 commits into from
May 17, 2024
Merged

Conversation

raphaelshirley
Copy link
Collaborator

@raphaelshirley raphaelshirley commented May 15, 2024

Closes #13

Basic example notebook running cosmos on a small number of objects that can be increased by the user

Problem & Solution Description (including issue #)

We will want to wait till latest Param changes are merged and rewrite before merging.

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

@raphaelshirley raphaelshirley self-assigned this May 15, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 7.14286% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 46.57%. Comparing base (14a5c3b) to head (dca196e).

Files Patch % Lines
src/rail/estimation/algos/lephare.py 7.14% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   49.63%   46.57%   -3.06%     
==========================================
  Files           2        2              
  Lines         137      146       +9     
==========================================
  Hits           68       68              
- Misses         69       78       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Raphael Shirley added 3 commits May 18, 2024 00:39
We load the config from the model and update some default values to enable the cosmos example notebook
…rail_lephare into issue/13/create-cosmos-example
Copy link
Collaborator

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@raphaelshirley raphaelshirley merged commit 3f512c3 into main May 17, 2024
4 of 6 checks passed
@raphaelshirley raphaelshirley deleted the issue/13/create-cosmos-example branch May 17, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create COSMOS example
2 participants