Setting lephare config from stage params #47
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting for other PRs to merge before merging to ensure config values consistent with updated string dict format
Closes #43
I want to wait for the lephare string dict changes and the COSMOS param defaults to merged before merging to ensure merge conflicts are handled correctly
Problem & Solution Description (including issue #)
The redshift grid was being read from the lepahre config which could be distinct from the stage params and cause a confusion. WE instead overwrite the lephare config from the params. This should allow the notebook to be sped up by setting a sparse redshift grid in the inform params.
Code Quality
#pragma: no cover
; in the case of a bugfix, a new test that breaks as a result of the bug has been added