Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting lephare config from stage params #47

Merged
merged 7 commits into from
May 17, 2024

Conversation

raphaelshirley
Copy link
Collaborator

@raphaelshirley raphaelshirley commented May 16, 2024

Waiting for other PRs to merge before merging to ensure config values consistent with updated string dict format

Closes #43

I want to wait for the lephare string dict changes and the COSMOS param defaults to merged before merging to ensure merge conflicts are handled correctly

Problem & Solution Description (including issue #)

The redshift grid was being read from the lepahre config which could be distinct from the stage params and cause a confusion. WE instead overwrite the lephare config from the params. This should allow the notebook to be sped up by setting a sparse redshift grid in the inform params.

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

Waiting for other PRs to merge before merging to ensure config values consistent with updated string dict format
@raphaelshirley raphaelshirley requested a review from drewoldag May 16, 2024 21:20
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 49.61%. Comparing base (8b60454) to head (2d33944).
Report is 6 commits behind head on main.

Current head 2d33944 differs from pull request most recent head f9d7ad0

Please upload reports for the commit f9d7ad0 to get more accurate results.

Files Patch % Lines
src/rail/estimation/algos/lephare.py 58.33% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   47.15%   49.61%   +2.46%     
==========================================
  Files           2        2              
  Lines         123      131       +8     
==========================================
+ Hits           58       65       +7     
- Misses         65       66       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. But I would like to hear what Johann or Alex have to say about using log spacing for the zgrid.

@raphaelshirley raphaelshirley merged commit 14a5c3b into main May 17, 2024
4 checks passed
@raphaelshirley raphaelshirley deleted the issue/43/make-redshift-grid-consistent branch May 17, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make redshift grid consistent
2 participants