Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated process returns to list of lephare.onesource objects #58

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

raphaelshirley
Copy link
Collaborator

This is a change to the lephare code and should be merged after the PyPI has been updated.

Closes #57

I will request a review when PyPI is updated and the tests start breaking

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

This is a change to the lephare code and should be merged after the PyPI has been updated.
@raphaelshirley
Copy link
Collaborator Author

The tests should start passing when PyPI is updated

@raphaelshirley raphaelshirley self-assigned this Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 45.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 44.73%. Comparing base (55ce8ce) to head (5ad27dc).

Files with missing lines Patch % Lines
src/rail/estimation/algos/lephare.py 45.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   46.57%   44.73%   -1.84%     
==========================================
  Files           2        2              
  Lines         146      152       +6     
==========================================
  Hits           68       68              
- Misses         78       84       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update process returns
1 participant