Mount venv as volume #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 10, 2025
github-merge-queue bot
pushed a commit
to LabAutomationAndScreening/copier-python-package-template
that referenced
this pull request
Jan 10, 2025
See LabAutomationAndScreening/copier-base-template#9 --------- Co-authored-by: Eli Fine <[email protected]>
github-merge-queue bot
pushed a commit
to LabAutomationAndScreening/pyalab
that referenced
this pull request
Jan 11, 2025
See LabAutomationAndScreening/copier-base-template#9 --------- Co-authored-by: Eli Fine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this change necessary?
Improve performance on Windows hosts
How does this change address the issue?
Moves the python venv folder into a dedicated separate docker volume
What side effects does this change have?
venv folder won't show up on local hard drive
How is this change tested?
In this repo, and pyalab repo and in pyalab codespace. pyalab Pytest execution time was previous 2 second in Codespaces and 16 seconds on Windows host---this dropped it to 4 seconds on Windows host.
Other
Bumped uv version