Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VinixMC.net #1031

Merged
merged 7 commits into from
Apr 3, 2024
Merged

Add VinixMC.net #1031

merged 7 commits into from
Apr 3, 2024

Conversation

vinixmc
Copy link
Contributor

@vinixmc vinixmc commented Mar 26, 2024

Type of change

  • Add new directory for a server
  • Update directory of a server
  • Remove directory of a server
  • Documentation Update

Checklist

  • I have read the README doc
  • I have compressed the images appropriately (e.g. on https://tinypng.com)
  • I have created the manifest.json with the required values

Further comments

minecraft_servers/vinixmc/manifest.json Outdated Show resolved Hide resolved
minecraft_servers/vinixmc/manifest.json Outdated Show resolved Hide resolved
minecraft_servers/vinixmc/manifest.json Outdated Show resolved Hide resolved
Copy link

Just as an information:
Your server play.vinixmc.net could be offline.
In general, we only accept pull requests from servers, that are online. Please change this, otherwise we cannot review your server correctly and have to deny the pull request.

If your server is currently online, then our api returned a wrong status, we will have a look at it :)

Reference: API URL (https://api.mcsrvstat.us/2/play.vinixmc.net)

@vinixmc
Copy link
Contributor Author

vinixmc commented Mar 26, 2024

Everything now is good, is a server wildcard required?

@maaaathis
Copy link
Contributor

Everything now is good, is a server wildcard required?

Nope, it's not required.

@vinixmc
Copy link
Contributor Author

vinixmc commented Mar 27, 2024

Everything now is good, is a server wildcard required?

Nope, it's not required.

How much does it take to verify or/and add the server?

@vinixmc
Copy link
Contributor Author

vinixmc commented Apr 2, 2024

Everything now is good, is a server wildcard required?

Nope, it's not required.

What happened? when the server will be added?

@maaaathis
Copy link
Contributor

Everything now is good, is a server wildcard required?

Nope, it's not required.

What happened? when the server will be added?

You need to remove the wildcard, if it's not a real wildcard.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • JSON is invalid! Workflow is not able to check minecraft_servers/vinixmc/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • JSON is invalid! Workflow is not able to check minecraft_servers/vinixmc/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

@vinixmc
Copy link
Contributor Author

vinixmc commented Apr 2, 2024

Everything now is good, is a server wildcard required?

Nope, it's not required.

What happened? when the server will be added?

You need to remove the wildcard, if it's not a real wildcard.

I have removed the wildcard

@vinixmc
Copy link
Contributor Author

vinixmc commented Apr 2, 2024

  • JSON is invalid! Workflow is not able to check minecraft_servers/vinixmc/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

@vinixmc vinixmc closed this Apr 2, 2024
@vinixmc vinixmc reopened this Apr 2, 2024
@DoJapHD DoJapHD merged commit f8d3d5a into LabyMod:master Apr 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants