[FIX] Rename jade to pug #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, initially I cloned this repo because I wanted to fix a UI bug in the released version where the title for the note is not shown, and instead the word title is shown. Then I realized that this bug was already fixed in
devbranch anddevbranch is way ahead of master.But I found another bug during the setup, that is caused by the renaming of
jadeintopugin theprismjspackage since1.8.2:This bug causes the web app to throw error and stop working due to missing dependency:
Ideally the change should not affect this project because the version of the
prismjspackage is defined as1.7.0inpackage-lock.json, but somehow1.7.0inpackage-lock.jsondoes not matchpackage.jsonwhich is"prismjs": "^1.8.1". So when I didnpm install, it fetchesprismjs:1.8.4and updatespackage-lock.json. Maybe you can regenerate thepackage-lock.jsonfile? I've checked outpackage-lock.jsonin this PR.FYI: npm's behavior regarding conflicting versions: