bug: prettierd not installing when using prettier extras

[briandipalma]

Did you check docs and existing issues?

• I have read all the LazyVim docs
• I have searched the existing issues of LazyVim
• I have searched the exsiting issues of plugins related to this issue

Neovim version (nvim -v)

NVIM v0.8.3

Operating system/version

Linux

Describe the bug

I saw you added extras for ESLint and Prettier so I uninstalled them and moved my configuration to using them, commit here.

I restart and open a few JS/TS files and the ESLint LSP installs fine and works/fixes a few issues. Prettierd though doesn't install...that's not what I would expect given:

opts: your custom opts will be merged with the default opts

Is it maybe the case that I need to order my plugin imports in a certain fashion or that the merging only happens for top level map values or the merging only happens once?

I've also noticed the dependency string for mason is just "mason.nvim" in some places, is that correct?

Steps To Reproduce

.

Expected Behavior

I'd expect prettierd to be installed.

Repro

-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")
-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath, })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  "folke/LazyVim",
  -- add any other plugins here
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here

[folke]

I was actually overwiting ensure_installed for mason, instead of extending it. Just fixed that.

Maybe you also override it in your personal config?

Check the commit above to see how to fix it

[folke]

https://github.com/briandipalma/ansible/blob/main/roles/common/files/nvim/lua/plugins/mason.lua

Either you should include prettierd there, or use a function as in the commit I referenced to correctly extend the list

[folke]

I've also noticed the dependency string for mason is just "mason.nvim" in some places, is that correct?

Yep, that works too

[briandipalma]

OK, the thing I don't understand then is how do all the various opts for "neovim/nvim-lspconfig" work? They are all opts tables and not functions that merge into an opts table.

[folke]

check the docs for vim.tbl_deep_extend

[PetarMetodiev]

Hey, I am also having the same issue - fresh install of LazyVim following the docs and added these lines:

    { import = "lazyvim.plugins.extras.linting.eslint" },
    { import = "lazyvim.plugins.extras.formatting.prettier" },

Everything besides prettierd gets automatically installed. Manually installing prettierd through mason doesn't seem to help - it still does not get picked up by null ls. Does this mean I have to follow the steps here? If so - what is the point of the prettier extra?

Sorry for hijacking the thread, seemed similar to my issue.

[folke]

same as what I mentioned before. You're overriding ensure_installed etc in your own config

[PetarMetodiev]

I am not sure about this - I did a quick grep in my config and didn't find any LSP related ensure_installed overrides. The only place I have it is here:

{
    "nvim-treesitter/nvim-treesitter",
    opts = {
      ensure_installed = {
        "bash",
        "css",
        "scss",
        "html",
        "javascript",
        "jsdoc",
        "json",
        "json5",
        "lua",
        "tsx",
        "typescript",
        "vim",
      },
    -- ...other ts options
    },
  }

There are some examples in the example.lua file but from what I can gather it is not being loaded.

[briandipalma]

I'd try with a clean set of config without any of your changes and only vanilla LazyVim. See if that works.

[PetarMetodiev]

Ok, so here are the results with a clean config and only modifying lazy.lua to have these lines:

    { import = "lazyvim.plugins.extras.linting.eslint" },
    { import = "lazyvim.plugins.extras.formatting.prettier" },

Looking at :Mason I see that all required LSPs are installed, including prettierd:

Looking at :LspInfo I see this:

null-ls doesn't seem to start automatically and is running in single file mode. I tried manually uninstalling and then installing prettier through mason but that didn't help. When I press <leader>cf (the default keymap for formatting) I see a message in the lower left corner of the editor which shows prettier but the code does not get formatted:

prettier-not-working.mov

[folke]

Prettierd is not an lsp.

Null-ls will always be shown as not starting automatically and in single file mode, that's all normal.

[PetarMetodiev]

Ah, I see. Thank you both for the help and thank you folke for making LazyVim - it is awesome!