Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Deprecated Console Output for Leaflet 1.2.0 #772

Merged
merged 6 commits into from
Oct 20, 2017

Conversation

wattnpapa
Copy link
Contributor

This fixes the Deptrecated Messages in Leaflet 1.2.0

bildschirmfoto 2017-08-23 um 13 43 51

@germanjoey
Copy link

Uh did you actually try this? I think you meant to include L.Evented, L.Events, and at any rate, you can't use .include directly on Leaflet.Class objects. You need to use something like, for example:

     var version = L.version.split(".");
     //If Version is >= 1.2.0
     if(parseInt(version[0],10) === 1 && parseInt(version[1],10) >= 2 ) {
         L.Toolbar.include(L.Evented.prototype);
     } else {
         L.Toolbar.include(L.Mixin.Events);
     }

etc

@wattnpapa
Copy link
Contributor Author

@germanjoey yes i tried it and it was working for me.
Do you have other insights?

@germanjoey
Copy link

Obviously, I tried it and it did not work for me. I had to change it to what I posted.

@barbalex
Copy link

I'd be real glad if this could be merged. My console is basically useless now

@wattnpapa
Copy link
Contributor Author

@ddproxy is there any reason for not accepting this MR ?
Have i to do something more?

@nzifnab
Copy link

nzifnab commented Sep 19, 2017

Looks like this happens on Leaflet 1.1.0 as well, but ya I'd love it if this could be merged in?

@neurosnap
Copy link

Any updates on this PR? How can I help?

@austingayler
Copy link

@ddproxy any update on this?

@tomfa
Copy link

tomfa commented Oct 20, 2017

+1

@ddproxy ddproxy merged commit 34f88da into Leaflet:master Oct 20, 2017
@austingayler
Copy link

Thanks!

@ddproxy
Copy link
Member

ddproxy commented Oct 20, 2017

Sorry for taking so long on this, I'm working up a release for today.

@BjornRombaut
Copy link

@ddproxy has this been released? I see the PR is merged, but can't seem to find a release that includes these changes.

@bidhan-a
Copy link

Bump

@ddproxy
Copy link
Member

ddproxy commented Nov 13, 2017

Sorry this has gone out to NPM today.

@austingayler
Copy link

@ddproxy Thanks! Appreciate everything that you do 💯

@bidhan-a
Copy link

bidhan-a commented Nov 14, 2017

Thanks @ddproxy and @powerpan , the console warnings are all gone now.

iminyukov pushed a commit to iminyukov/Leaflet.draw that referenced this pull request Apr 19, 2018
Fix Deprecated Console Output for Leaflet 1.2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants