Rework Legacy PNG Icons with Font Awesome SVG #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hswong3i
force-pushed
the
icon_with_svg
branch
from
f9e5a05
to
e002bf1
Compare
Existing implementation handle icon with PNG, with manual positioning
with CSS background image.
This PR rework icons with Font Awesome SVG:
- Locally venor Font Awesome v5.15.4 `expand-solid.svg` and
`compress-solid.svg`
- Rework styling with SCSS
- Fix accessibility (see Leaflet#110)
- Test with Leaflet v1.7.1
- Update demo with above changes
Fix Leaflet#98
Fix Leaflet#102
Fix Leaflet#103
Fix Leaflet#110
Fix Leaflet#114
Signed-off-by: Wong Hoi Sing Edison <[email protected]>
hswong3i
force-pushed
the
icon_with_svg
branch
from
e002bf1
to
27056dc
Compare
|
Unfortunately - no one with access to merge PRs seems to be looking at this repo. If you want to see a fork with all of the PRs added (including this one) - see https://github.com/runette/Leaflet.fullscreen and the npm package as below (version 1.0.6 includes this PR) : |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing implementation handle icon with PNG, with manual positioning with CSS background image.
This PR rework icons with Font Awesome SVG:
expand-solid.svgandcompress-solid.svgrole="button"#110)Fix #98
Fix #102
Fix #103
Fix #110
Fix #114
Online demo: https://drustack.github.io/Leaflet-Leaflet.fullscreen/
Signed-off-by: Wong Hoi Sing Edison [email protected]