-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tooltip anchor locations are incorrect for small GeoJSON polygons in 1.9.x #8783
Comments
Any news about this ? |
We have already a PR (#8784) for this, but the PR needs first to be merged and then a Release is necessary. So this will take a while. |
When you say a while you mean weeks ? months ? We can't use Leaflet for our new project due to this... |
You can use Leaflet |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@Falke-Design Thanks for the pull request! I was suspicious of something like rounding that but didn't do a great job of debugging due to unfamiliarity with the project structure. Looking forward to the release but using 1.8.0 until then. BTW we frequently use 7+ decimal places to annotate small objects... works well so far but hoping we dont run in to precision issues if we go much smaller. |
Issue fixed by #8784, will be in the next |
This is affecting us too. Thanks for the fix! We're looking forward to the next release. |
@foxymiles @michaelthoreau @Mushr0000m we just released |
@Falke-Design Thanks for the update! |
Checklist
Steps to reproduce
This JSFiddle Illustrates the problem well: https://jsfiddle.net/michaelthoreau/ekafvph8/6/
This issue seems to only affect geojson polygons that are geographically small, regardless of pixel size when drawn.
Expected behavior
Both tooltips should appear centered on the polygons.
Current behavior
The smaller polygon's tooltip appears in the wrong position. This behaviour does not appear in [email protected].
Minimal example reproducing the issue
https://jsfiddle.net/michaelthoreau/ekafvph8/6/
Environment
The text was updated successfully, but these errors were encountered: