Fix rounding errors in center calculation for small layers #8784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
4 tasks
Falke-Design
added
the
blocker
|
We should release this fix. @mourner @jonkoops @IvanSanchez can you please review. |
jonkoops
requested changes
Feb 11, 2023
Falke-Design
commented
Feb 12, 2023
IvanSanchez
previously requested changes
Feb 13, 2023
Falke-Design
dismissed
IvanSanchez’s stale review
Quote Ivan "I'm OK with that [...]"
Falke-Design
added a commit
that referenced
this pull request
Feb 28, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For small areas, the center was to far away of the layer. It looks like the reason are rounding errors (Thx to turf.js for the idea: https://github.com/Turfjs/turf/blob/master/packages/turf-center-of-mass/index.ts#L39). But this solution doesn't work good for normal / larger areas, so I added a check if the area of the bounds are small then
1700it using the rounding preventing solution.To solve this I needed to add the new function
PolyUtil.centroid.This needs merged in the
mainbanche too.error:
fixed:
Fixes #8783
PS: I also cleaned up some unnecessary tests.