Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big bang #259

Merged
merged 14 commits into from
Apr 29, 2024
Merged

Big bang #259

merged 14 commits into from
Apr 29, 2024

Conversation

sgliner-ledger
Copy link
Contributor

No description provided.

@sgliner-ledger sgliner-ledger force-pushed the big-bang branch 3 times, most recently from 48094cf to 3169075 Compare January 31, 2024 16:38
@ledger-wiz-cspm-secret-detection
Copy link

ledger-wiz-cspm-secret-detection bot commented Mar 20, 2024

Wiz Scan Summary

IaC Misconfigurations 0C 0H 0M 0L 0I
Total 0C 0H 0M 0L 0I
Secrets 0🔑

@sgliner-ledger sgliner-ledger force-pushed the big-bang branch 2 times, most recently from 0ab9335 to a255bb5 Compare April 4, 2024 08:04
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

@xchapron-ledger xchapron-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md could be revamped too.

Makefile Outdated Show resolved Hide resolved
@xchapron-ledger
Copy link
Contributor

xchapron-ledger commented Apr 4, 2024

Some glyphs in /glyphs could be removed too (icon_* they are in the SDK).

@xchapron-ledger
Copy link
Contributor

Could ci-workflow be based on boilerplate build_and_functional_tests.yml?

@xchapron-ledger
Copy link
Contributor

Could be nice to add C and python linter.

tests/test_sign.py Outdated Show resolved Hide resolved
Remove deprecated handlers, only supported mode is wallet
U2F is no longer supported
set_check_internal_structure_integrity: remove empty function
dead code and use functions from SDk
standardize, and replace coin_config structure with defines
swap: use global variable from standard swap and move to dedicated folder
@sgliner-ledger sgliner-ledger merged commit b07dc06 into develop Apr 29, 2024
99 of 104 checks passed
@sgliner-ledger sgliner-ledger deleted the big-bang branch April 29, 2024 14:14
@PiRK
Copy link

PiRK commented May 27, 2024

So how do I connect to a Ledger device using python, when the device is not in BTC mode, now that you broke the compatibility with btchip?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants