Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge develop into master #268

Merged
merged 103 commits into from
May 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
103 commits
Select commit Hold shift + click to select a range
c9bd7eb
gitignore: ignore build folder
sgliner-ledger Mar 30, 2023
97cf768
glyphs and icons: update for stax and apply guidelines
sgliner-ledger Apr 4, 2023
305ff2a
ui: move ui related code to dedicated file
sgliner-ledger Sep 1, 2022
a37c200
Fatstacks: prepare for fatstack ui
sgliner-ledger Sep 1, 2022
52e0689
btchip_context: add buffer for coin logo in globals
sgliner-ledger Sep 12, 2022
1e18abb
nbgl: add fatstacks related ui
sgliner-ledger Sep 12, 2022
f536c4b
tests: adapt for Stax
sgliner-ledger Apr 3, 2023
79dfc0d
glyphs: remove outdated blue glyphs
sgliner-ledger Apr 4, 2023
5f1b709
workflows: update ci for stax
sgliner-ledger Apr 5, 2023
ed5aa70
[clean] Follow Ledger guidelines
sgliner-ledger Apr 5, 2023
ac4949b
gitignore: remove glyphs
sgliner-ledger Apr 12, 2023
8f886a4
Makefile: bump version
sgliner-ledger Apr 12, 2023
98be477
clang: add fallthrough attributes
sgliner-ledger Apr 13, 2023
6f39753
Merge pull request #235 from LedgerHQ/stax-porting
sgliner-ledger Apr 18, 2023
4d195ca
ui_nbgl: pubkey flow uses useCase
sgliner-ledger Apr 21, 2023
8c1b316
Makefile: bump version
sgliner-ledger Apr 21, 2023
f290300
Merge pull request #236 from LedgerHQ/usecase-address
sgliner-ledger Apr 21, 2023
98f31b1
ui_nbgl: change some wordings
sgliner-ledger May 26, 2023
96fe2ef
Clang: fix warnings
sgliner-ledger May 26, 2023
47f31e9
ui_nbgl: unify transaction flow
sgliner-ledger May 26, 2023
0ca5e10
Makefile: improve file inclusion from SDK
sgliner-ledger May 30, 2023
baf09df
ui_nbgl: replace empty strings by NULL
sgliner-ledger May 30, 2023
270052f
Bump version
sgliner-ledger May 30, 2023
6d007d0
Merge pull request #238 from LedgerHQ/functional-review
sgliner-ledger May 30, 2023
9fc54a6
ui_nbgl: Use coin name instead of hardcoded string
sgliner-ledger May 31, 2023
0eae350
Merge pull request #239 from LedgerHQ/fix-wrong-name
sgliner-ledger May 31, 2023
30e227d
Erase BSS when started in SWAP mode
fbeutin-ledger Jun 21, 2023
cbaed7c
Bump version
fbeutin-ledger Jun 22, 2023
0351fbe
Merge pull request #240 from LedgerHQ/fbe/erase_bss
fbeutin-ledger Jun 22, 2023
12d0723
Makefile: Bump version
sgliner-ledger Jul 4, 2023
c972238
Settings: Update according to latest guidelines
sgliner-ledger Jul 17, 2023
6b19e4a
stax: update some wording
sgliner-ledger Jul 17, 2023
9ddc613
icons: update with new design for stax
sgliner-ledger Jul 17, 2023
9e1e9cd
handleGetWalletId: use no-throw crypto api
sgliner-ledger Jul 18, 2023
2d2bf0a
btchip.c: remove try/catch
sgliner-ledger Jul 18, 2023
f597f46
btchip_private_derive_keypair: use no-throw apis and handle return code
sgliner-ledger Jul 18, 2023
0178db3
get_pubkey: use no-throw crypto API
sgliner-ledger Jul 18, 2023
05b29f7
btchip_sign_finalhash: use no-throw api
sgliner-ledger Jul 18, 2023
df512fc
handle_check_address: use no-throw api
sgliner-ledger Jul 18, 2023
371a0b8
btchip_transaction: use no-throw crypto API
sgliner-ledger Jul 18, 2023
243023d
btchip_apdu_hash_input_finalize_full: use no_throw api
sgliner-ledger Jul 18, 2023
1874bf2
btchip_apdu_sign_message: use no-throw api
sgliner-ledger Jul 18, 2023
20722a4
btchip_apdu_sign_message: remove try/catch
sgliner-ledger Jul 18, 2023
4c61431
crypto calls: use no throw api
sgliner-ledger Jul 18, 2023
2b98d5f
[clean] remove HAVE_WALLET_ID_SDK related code
sgliner-ledger Jul 24, 2023
0866670
[Clean]: btchip_apdu_get_trusted_input: remove useless cast
sgliner-ledger Jul 24, 2023
09cb67a
hash256: use single function instead of init and hash
sgliner-ledger Jul 24, 2023
c2a3d3c
btchip_sign_finalhash: use path instead of private key to generate si…
sgliner-ledger Jul 26, 2023
cc2b72f
btchip_get_public_key: derive public key directly from path
sgliner-ledger Jul 26, 2023
7815af3
btchip_private_derive_keypair: remove useless calls
sgliner-ledger Jul 26, 2023
c318857
btchip_helpers: use function to parse serialized path
sgliner-ledger Jul 26, 2023
b258fbd
Merge pull request #241 from LedgerHQ/review2
sgliner-ledger Jul 31, 2023
e818ad7
apdu_sign_message: cx_hash_sha256 fix return check
sgliner-ledger Aug 4, 2023
b0d5fa0
message signature: fix buffer
sgliner-ledger Aug 4, 2023
26914d5
tests: add sign message
sgliner-ledger Aug 4, 2023
12c0035
Makefile: Bump version
sgliner-ledger Aug 4, 2023
eaca87d
Merge pull request #243 from LedgerHQ/fix-sign-message
sgliner-ledger Aug 7, 2023
7e3a269
QR code source path is now used explicitly
apaillier-ledger Aug 3, 2023
e7a78fb
Merge pull request #242 from LedgerHQ/fix/apa/explicit_qrcode_source_…
sgliner-ledger Aug 7, 2023
7e2908c
Makefile: remove COIN_COLOR_HDR and COIN_COLOR_DB
sgliner-ledger Oct 26, 2023
6ecc089
clean: fix clang analyzer
sgliner-ledger Oct 26, 2023
4e7b030
Qtum: remove associated code and mark variant as deprecated
sgliner-ledger Oct 26, 2023
6e3b8ff
Merge pull request #246 from LedgerHQ/clean-old-defines
sgliner-ledger Oct 26, 2023
bfe0af4
Update README.md
tdejoigny-ledger Oct 26, 2023
b073c9a
Merge pull request #248 from LedgerHQ/tdj/readme_update
tdejoigny-ledger Oct 27, 2023
b983dfa
Add cross CI for swap features
fbeutin-ledger Nov 7, 2023
e3ee06c
Merge pull request #250 from LedgerHQ/fbe/add_swap_cross_ci
fbeutin-ledger Nov 7, 2023
2e14303
Add a spinner on Stax when started via Exchange and return to Exchang…
fbeutin-ledger Nov 13, 2023
d310e4e
Merge pull request #251 from LedgerHQ/fbe/improve_exchange_ui
fbeutin-ledger Nov 13, 2023
ac481eb
[auto]: add PR template
sgliner-ledger Nov 29, 2023
bb60cde
[add] ledger_app.toml manifest
lpascal-ledger Dec 1, 2023
1b0ac85
Merge pull request #255 from LedgerHQ/add/manifest
lpascal-ledger Dec 1, 2023
f58ec31
clean: add LEDGER_ASSERT to handle errors
sgliner-ledger Dec 5, 2023
61f525d
Merge pull request #252 from LedgerHQ/fix-analyzer
sgliner-ledger Dec 19, 2023
1c11745
[auto] Update screenshot
sgliner-ledger Feb 27, 2024
f1c37d7
btchip_context: change bip44_coin_type type to prevent overflow
sgliner-ledger Mar 4, 2024
f5f5923
Merge pull request #263 from LedgerHQ/clang-analyzer
sgliner-ledger Mar 4, 2024
c6a80ae
Fix Horizen transaction output checks
Feb 7, 2024
cc9e6fd
Fix signed message magic for Horizen
drgora Feb 20, 2024
8d29f5b
Bump version
drgora Feb 20, 2024
0a84516
bump version
sgliner-ledger Mar 29, 2024
61c4ce2
Merge pull request #265 from LedgerHQ/bump-version
sgliner-ledger Mar 29, 2024
0eda743
Tests: Remove useless files
sgliner-ledger Mar 14, 2024
9d5e748
First import of ragger_bitcoin
sgliner-ledger Mar 12, 2024
4448fc6
tests: update with ragger
sgliner-ledger Mar 15, 2024
61770ea
Tests: add screenshots
sgliner-ledger Mar 27, 2024
431aae3
Bye Bye btchip
sgliner-ledger Mar 27, 2024
2c61ac0
Cleaning and standardizing
sgliner-ledger Mar 27, 2024
a91ced4
Remove throw, use standard app layout, clean, and move to its own lib
sgliner-ledger Feb 2, 2024
22a1e6f
Lint: apply clang-format
sgliner-ledger Apr 4, 2024
45277ba
Doc: update readme and add comments for WEAK functions
sgliner-ledger Apr 29, 2024
569d640
Makefile: harmonize COIN_COINID_NAME with APPNAME
sgliner-ledger Apr 22, 2024
fb86e8e
NBGL: replace deprecated warning icon
sgliner-ledger Apr 16, 2024
7642c5d
NBGL: change ui for flex porting
sgliner-ledger Apr 16, 2024
9b5f877
Tests: update with latest changes
sgliner-ledger Apr 19, 2024
5e51b80
Tests: update snapshots
sgliner-ledger Apr 22, 2024
b07dc06
Merge pull request #259 from LedgerHQ/big-bang
sgliner-ledger Apr 29, 2024
b5ffad8
Makefile: remove unused COIN_COINID_HEADER field
sgliner-ledger Apr 30, 2024
5dfab58
lib-app-bitcoin: replace with submodule
sgliner-ledger May 2, 2024
1bc2738
Tests: update snapshots
sgliner-ledger May 2, 2024
4d86f74
coding_style_checks: remove now that all sources are in submodule
sgliner-ledger May 2, 2024
b01037a
Makefile: bump version
sgliner-ledger May 2, 2024
4c080bf
Merge pull request #266 from LedgerHQ/move-lib-into-submodule
sgliner-ledger May 2, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
8 changes: 8 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# Checklist
<!-- Put an `x` in each box when you have completed the items. -->
- [ ] App update process has been followed <!-- See comment below -->
- [ ] Target branch is `develop` <!-- unless you have a very good reason -->
- [ ] Application version has been bumped <!-- required if your changes are to be deployed -->

<!-- Make sure you followed the process described in https://developers.ledger.com/docs/device-app/deliver/maintenance before opening your Pull Request.
Don't hesitate to contact us directly on Discord if you have any questions ! https://developers.ledger.com/discord -->
33 changes: 33 additions & 0 deletions .github/workflows/build_and_functional_tests.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
name: Build and run functional tests using ragger through reusable workflow

# This workflow will build the app and then run functional tests using the Ragger framework upon Speculos emulation.
# It calls a reusable workflow developed by Ledger's internal developer team to build the application and upload the
# resulting binaries.
# It then calls another reusable workflow to run the Ragger tests on the compiled application binary.
#
# While this workflow is optional, having functional testing on your application is mandatory and this workflow and
# tooling environment is meant to be easy to use and adapt after forking your application

on:
workflow_dispatch:
push:
branches:
- master
- main
- develop
pull_request:

jobs:
build_application:
name: Build application using the reusable workflow
uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_build.yml@v1
with:
upload_app_binaries_artifact: "compiled_app_binaries"
flags: "COIN=bitcoin_testnet_legacy"

ragger_tests:
name: Run ragger tests using the reusable workflow
needs: build_application
uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_ragger_tests.yml@v1
with:
download_app_binaries_artifact: "compiled_app_binaries"
69 changes: 0 additions & 69 deletions .github/workflows/ci-workflow.yml

This file was deleted.

23 changes: 23 additions & 0 deletions .github/workflows/guidelines_enforcer.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Ensure compliance with Ledger guidelines

# This workflow is mandatory in all applications
# It calls a reusable workflow guidelines_enforcer developed by Ledger's internal developer team.
# The successful completion of the reusable workflow is a mandatory step for an app to be available on the Ledger
# application store.
#
# More information on the guidelines can be found in the repository:
# LedgerHQ/ledger-app-workflows/

on:
workflow_dispatch:
push:
branches:
- master
- main
- develop
pull_request:

jobs:
guidelines_enforcer:
name: Call Ledger guidelines_enforcer
uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_guidelines_enforcer.yml@v1
16 changes: 16 additions & 0 deletions .github/workflows/swap-ci-workflow.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
name: Swap functional tests

on:
workflow_dispatch:
push:
branches:
- master
- develop
pull_request:

jobs:
job_functional_tests:
uses: LedgerHQ/app-exchange/.github/workflows/reusable_swap_functional_tests.yml@develop
with:
branch_for_bitcoin_legacy: ${{ github.ref }}
test_filter: '"ltc or litecoin or Litecoin"'
4 changes: 2 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ bin
debug
dep
obj
src/glyphs.c
src/glyphs.h
*.pyc
.idea
.vscode
build
tests/snapshots-tmp
3 changes: 3 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[submodule "lib-app-bitcoin"]
path = lib-app-bitcoin
url = [email protected]:LedgerHQ/lib-app-bitcoin.git
Loading
Loading