Fixes LL-8516 (#1550)

* Fixes LL-8516

- LL-8516 bsc and polygon won't display nfts yet
- disabling NFT back to false will make .nfts go back to undefined with a full resync
- enabling it back will also make a full sync & reappear (like before)
- a clear cache will remove all .nfts for making sure a full resync happens
- more tests added to prove LL-8516
- a NFT_CURRENCIES env is made available and set at "ethereum" for now

* disable test for polygon because backend have issues

* update generated md

* lint

explorers-config.md

@@ -16,6 +16,7 @@
 | Litecoin | LTC | https://explorers.api.live.ledger.com/blockchain/v3/ltc | N/A |
 | Peercoin | PPC | https://explorers.api.live.ledger.com/blockchain/v3/ppc | N/A |
 | PivX | PIVX | https://explorers.api.live.ledger.com/blockchain/v3/pivx | N/A |
+| Polygon | MATIC | https://explorers.api.live.ledger.com/blockchain/v3/matic | N/A |
 | Qtum | QTUM | https://explorers.api.live.ledger.com/blockchain/v3/qtum | N/A |
 | Stakenet | XSN | https://explorers.api.live.ledger.com/blockchain/v3/xsn | N/A |
 | Vertcoin | VTC | https://explorers.api.live.ledger.com/blockchain/v3/vtc | N/A |

src/__tests__/test-helpers/setup.ts

@@ -21,6 +21,7 @@ setSupportedCurrencies([
   "bitcoin",
   "ethereum",
   "bsc",
+  "polygon",
   "elrond",
   "ripple",
   "bitcoin_cash",

src/account/helpers.ts

@@ -150,6 +150,7 @@ export function clearAccount<T extends AccountLike>(account: T): T {
     copy.bitcoinResources = initialBitcoinResourcesValue;
   }
   delete copy.balanceHistory;
+  delete copy.nfts;
   return copy as T;
 }
 export function findSubAccountById(

src/api/Ethereum.ts

@@ -10,6 +10,7 @@ import { blockchainBaseURL } from "./Ledger";
 import { FeeEstimationFailed } from "../errors";
 import { makeLRUCache } from "../cache";
 import { getEnv } from "../env";
+import { isNFTActive } from "../nft/support";
 
 export type Block = {
   height: BigNumber;
@@ -132,10 +133,9 @@ export const apiForCurrency = (currency: CryptoCurrency): API => {
       let { data } = await network({
         method: "GET",
         url: URL.format({
-          pathname:
-            getEnv("NFT") && currency.ticker === "ETH"
-              ? `https://explorers.api-01.live.ledger-stg.com/blockchain/v3/eth/addresses/${address}/transactions`
-              : `${baseURL}/addresses/${address}/transactions`,
+          pathname: isNFTActive(currency)
+            ? `https://explorers.api-01.live.ledger-stg.com/blockchain/v3/eth/addresses/${address}/transactions`
+            : `${baseURL}/addresses/${address}/transactions`,
           query: {
             batch_size,
             noinput: true,

src/env.ts

@@ -381,6 +381,11 @@ const envDefinitions = {
     parser: boolParser,
     desc: "synchronizing nfts",
   },
+  NFT_CURRENCIES: {
+    def: "ethereum",
+    parser: stringParser,
+    desc: "set the currencies where NFT is active",
+  },
   NFT_ETH_METADATA_SERVICE: {
     // FIXME LL-8001
     def: "https://nft.staging.aws.ledger.fr/v1/ethereum/1/contracts/tokens/infos",

src/families/ethereum/nft.test.ts

@@ -7,6 +7,8 @@ import { makeBridgeCacheSystem } from "../../bridge/cache";
 import { patchAccount } from "../../reconciliation";
 import { setEnv } from "../../env";
 
+jest.setTimeout(120000);
+
 const gaspardAccount: AccountRaw = {
   id: "js:1:ethereum:0xb98d10d9f6d07ba283bfd21b2dfec050f9ae282a:",
   seedIdentifier: "0xb98d10d9f6d07ba283bfd21b2dfec050f9ae282a",
@@ -26,32 +28,74 @@ const gaspardAccount: AccountRaw = {
   xpub: "",
 };
 
-describe("nft reconciliation", () => {
-  let account = fromAccountRaw(gaspardAccount);
-  const localCache = {};
-  const cache = makeBridgeCacheSystem({
-    saveData(c, d) {
-      localCache[c.id] = d;
-      return Promise.resolve();
-    },
-    getData(c) {
-      return Promise.resolve(localCache[c.id]);
-    },
-  });
+/*
+const gaspardPolygonAccount: AccountRaw = {
+  id: "js:1:polygon:0xb98d10d9f6d07ba283bfd21b2dfec050f9ae282a:",
+  seedIdentifier: "0xb98d10d9f6d07ba283bfd21b2dfec050f9ae282a",
+  name: "G4sp4rd",
+  derivationMode: "",
+  index: 0,
+  freshAddress: "0xb98d10d9f6d07ba283bfd21b2dfec050f9ae282a",
+  freshAddressPath: "44'/60'/0'/0/0",
+  freshAddresses: [],
+  pendingOperations: [],
+  operations: [],
+  currencyId: "polygon",
+  unitMagnitude: 18,
+  balance: "",
+  blockHeight: 0,
+  lastSyncDate: "",
+  xpub: "",
+};
+*/
+
+const gaspardBscAccount: AccountRaw = {
+  id: "js:1:bsc:0xb98d10d9f6d07ba283bfd21b2dfec050f9ae282a:",
+  seedIdentifier: "0xb98d10d9f6d07ba283bfd21b2dfec050f9ae282a",
+  name: "G4sp4rd",
+  derivationMode: "",
+  index: 0,
+  freshAddress: "0xb98d10d9f6d07ba283bfd21b2dfec050f9ae282a",
+  freshAddressPath: "44'/60'/0'/0/0",
+  freshAddresses: [],
+  pendingOperations: [],
+  operations: [],
+  currencyId: "bsc",
+  unitMagnitude: 18,
+  balance: "",
+  blockHeight: 0,
+  lastSyncDate: "",
+  xpub: "",
+};
+
+async function sync(account, withNFT = true) {
   const bridge = getAccountBridge(account);
-  async function sync(account) {
-    const blacklistedTokenIds = [];
-    setEnv("NFT", true);
-    const r = await bridge
-      .sync(account, {
-        paginationConfig: {},
-        blacklistedTokenIds,
-      })
-      .pipe(reduce((a, f: (arg0: Account) => Account) => f(a), account))
-      .toPromise();
-    setEnv("NFT", false);
-    return r;
-  }
+  const blacklistedTokenIds = [];
+  setEnv("NFT", withNFT);
+  const r = await bridge
+    .sync(account, {
+      paginationConfig: {},
+      blacklistedTokenIds,
+    })
+    .pipe(reduce((a, f: (arg0: Account) => Account) => f(a), account))
+    .toPromise();
+  setEnv("NFT", false);
+  return r;
+}
+
+const localCache = {};
+const cache = makeBridgeCacheSystem({
+  saveData(c, d) {
+    localCache[c.id] = d;
+    return Promise.resolve();
+  },
+  getData(c) {
+    return Promise.resolve(localCache[c.id]);
+  },
+});
+
+describe("gaspard NFT on ethereum", () => {
+  let account = fromAccountRaw(gaspardAccount);
 
   test("first sync & have nfts", async () => {
     await cache.prepareCurrency(account.currency);
@@ -87,4 +131,43 @@ describe("nft reconciliation", () => {
     const newAccount = patchAccount(copy, toAccountRaw(account));
     expect(newAccount.nfts).toEqual(account.nfts);
   });
+
+  test("start account with .nfts and disable the NFT flag should make it disappear", async () => {
+    expect(account.nfts).not.toBeFalsy();
+    const resync = await sync(account, false);
+    expect(resync.nfts).toBeFalsy();
+  });
+
+  test("start account without .nfts and enable the NFT flag should make it appear", async () => {
+    const first = await sync(account, false);
+    expect(first.nfts).toBeFalsy();
+    const second = await sync(first, true);
+    expect(second.nfts).not.toBeFalsy();
+    expect(second.nfts).toEqual(account.nfts);
+  });
+});
+
+/*
+// this is never ending here... have to disable this test... (backend issue)
+describe("gaspard NFT on polygon", () => {
+  let account = fromAccountRaw(gaspardPolygonAccount);
+  test("first sync", async () => {
+    await cache.prepareCurrency(account.currency);
+    account = await sync(account);
+  });
+  test(".nfts shouldn't be visible", () => {
+    expect(account.nfts).toBeFalsy();
+  });
+});
+*/
+
+describe("gaspard NFT on bsc", () => {
+  let account = fromAccountRaw(gaspardBscAccount);
+  test("first sync", async () => {
+    await cache.prepareCurrency(account.currency);
+    account = await sync(account);
+  });
+  test(".nfts shouldn't be visible", () => {
+    expect(account.nfts).toBeFalsy();
+  });
 });

src/families/ethereum/signOperation.ts

@@ -13,7 +13,7 @@ import { getGasLimit, buildEthereumTx } from "./transaction";
 import { apiForCurrency } from "../../api/Ethereum";
 import { withDevice } from "../../hw/deviceAccess";
 import { modes } from "./modules";
-import { getEnv } from "../../env";
+import { isNFTActive } from "../../nft";
 export const signOperation = ({
   account,
   deviceId,
@@ -61,7 +61,7 @@ export const signOperation = ({
                 "0x" + (tx.value.toString("hex") || "0")
               );
               const eth = new Eth(transport);
-              if (getEnv("NFT")) {
+              if (isNFTActive(account.currency)) {
                 eth.setLoadConfig({
                   // FIXME drop this after LL-8001
                   nftExplorerBaseURL: