Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

Added logo to IndexCoop Tokens #1479

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Conversation

ripples3
Copy link

Context (issues, jira)

None

Description / Usage

Added logo for Alchemist https://etherscan.io/token/0x88acdd2a6425c3faae4bc9650fd7e27e0bebb7ab

Expectations

  • Test coverage: The changes of this PR are covered by test. Unit test were added with mocks when depending on a backend/device.
  • No impact: The changes of this PR have ZERO impact on the userland. Meaning, we can use these changes without modifying LLD/LLM at all. It will be a "noop" and the maintainers will be able to bump it without changing anything.

@ripples3 ripples3 requested a review from a team October 22, 2021 14:13
@vercel
Copy link

vercel bot commented Oct 22, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ledgerhq/ledger-live-common/ENKBqtXBTVXCG1KF7kmMYyG3viZw
✅ Preview: https://ledger-live-common-git-fork-ripples3-mist-ledgerhq.vercel.app

need to updated the file
@gre gre added the coin-icon label Oct 26, 2021
@ripples3 ripples3 changed the title Mist Added logo to IndexCoop Tokens Oct 28, 2021
@ripples3
Copy link
Author

any update on this? I have also requested the ledger to add tokens here.
https://developers.ledger.com/docs/token/erc20-bep20/#2-how-to-get-my-token-listed

@gre
Copy link
Contributor

gre commented Dec 7, 2021

Thanks for the contribution. could you merge master in? we have extra test that do some checks to ensure icons are fine. Thanks

@ripples3
Copy link
Author

ripples3 commented Dec 9, 2021

@gre I merge master in. Let me know if you have concerns.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants