Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

LL-8545 fix ticker regex issue #1559

Merged
merged 1 commit into from
Dec 6, 2021
Merged

LL-8545 fix ticker regex issue #1559

merged 1 commit into from
Dec 6, 2021

Conversation

LFBarreto
Copy link
Contributor

@LFBarreto LFBarreto commented Dec 3, 2021

  • (filterServiceStatusIncidents): fix issue in regex for some cases of tickers breaking the filter

Context (issues, jira)

LedgerHQ/ledger-live-desktop#4371

LL-8545

Description / Usage

Expectations

  • Test coverage: The changes of this PR are covered by test. Unit test were added with mocks when depending on a backend/device.
  • No impact: The changes of this PR have ZERO impact on the userland. Meaning, we can use these changes without modifying LLD/LLM at all. It will be a "noop" and the maintainers will be able to bump it without changing anything.

@LFBarreto LFBarreto requested a review from a team as a code owner December 3, 2021 12:56
@vercel
Copy link

vercel bot commented Dec 3, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ledgerhq/ledger-live-common/HT6NAWizmgDQohWD9KrNMpXXXyQ4
✅ Preview: https://ledger-live-common-git-fix-ticker-regex-issue-ledgerhq.vercel.app

@LFBarreto LFBarreto changed the title fix ticker regex issue LL-8545 fix ticker regex issue Dec 3, 2021
@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #1559 (38ebd6a) into master (4203d87) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1559   +/-   ##
=======================================
  Coverage   55.42%   55.43%           
=======================================
  Files         506      506           
  Lines       20442    20442           
  Branches     5062     5062           
=======================================
+ Hits        11330    11331    +1     
+ Misses       9066     9065    -1     
  Partials       46       46           
Impacted Files Coverage Δ
src/range.ts 92.30% <0.00%> (+2.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4203d87...38ebd6a. Read the comment docs.

@gre gre merged commit 8d4600d into master Dec 6, 2021
@gre gre deleted the fix-ticker-regex-issue branch December 6, 2021 08:33
@LFBarreto LFBarreto mentioned this pull request Dec 18, 2021
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants