Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

LIVE-826 - Learn page URL - Add environment var to enable learn staging URL #1748

Merged
merged 2 commits into from
Mar 3, 2022

Conversation

ofreyssinet-ledger
Copy link
Contributor

@ofreyssinet-ledger ofreyssinet-ledger commented Feb 25, 2022

Context (issues, jira)

We are developing a new "Learn" screen in LLD and LLM and it's basically an iframe loading an URL.
This URL can be a staging or a prod URL.
This PR introduces an environment variable that can be used to switch between the 2 kinds (prod or staging) of URL for the Learn page.
It will help us providing builds that the e-commerce team - the team developing that Learn website - can test with either URLs.
LIVE-826

Description / Usage

Used in LLM to add a developer setting:
LedgerHQ/ledger-live-mobile@61db1cc

Expectations

  • Test coverage: The changes of this PR are covered by test. Unit test were added with mocks when depending on a backend/device.
  • No impact: The changes of this PR have ZERO impact on the userland. Meaning, we can use these changes without modifying LLD/LLM at all. It will be a "noop" and the maintainers will be able to bump it without changing anything.

@ofreyssinet-ledger ofreyssinet-ledger requested a review from a team as a code owner February 25, 2022 16:07
@vercel
Copy link

vercel bot commented Feb 25, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ledgerhq/ledger-live-common/A2WfqpAL6mzkYrcbN64qU4JXpBSi
✅ Preview: https://ledger-live-common-git-learn-staging-url-env-ledgerhq.vercel.app

@ofreyssinet-ledger
Copy link
Contributor Author

thanks @haammar-ledger !

@ofreyssinet-ledger ofreyssinet-ledger merged commit 22c58d8 into develop Mar 3, 2022
@ofreyssinet-ledger ofreyssinet-ledger deleted the learn-staging-url-env branch March 3, 2022 09:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant