-
Notifications
You must be signed in to change notification settings - Fork 171
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/ledgerhq/ledger-live-common/DhY9dqfbt2CaoLNGXzAaDv3RPpgi |
Still have some work on CI to do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is largely a rework of the XRP impl, good job!
I'm thinking it will probably need some non-reg in addition to testing the linked issue...
Also maybe that rework is the occasion to split that huge js.ts
bridge file into appropriate js-*.ts
files. But not really mandatory. 😄
Well I think the issues was related to websocket, since it doesn't open properly so I don't know if I can reproduce it with test right now :/ |
I think we need to set up a bot for it and do our own QA first. 🙏 |
@henrily-ledger @haammar-ledger I have changed the base to be |
* LIVE-1341: Remove xrp lib * update .lock * remove other currency than XRP * Remove String and use toString + typescript fix
Context (issues, jira)
https://ledgerhq.atlassian.net/browse/LIVE-1341
Description / Usage
Replace Websocket of XRP with JSON-RPC should be more stable cause the websocket was not handle properly.
We should probably retest XRP and all these use case properly
Expectations