Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

LIVE-1944 Update Polkadot dependencies #1898

Merged
3 commits merged into from
Apr 29, 2022
Merged

Conversation

ghost
Copy link

@ghost ghost commented Apr 15, 2022

Context (issues, jira)

https://ledgerhq.atlassian.net/browse/LIVE-1944

Description / Usage

Update Polkadot packages from 7.8.1 to 8.0.2

Expectations

  • Test coverage: The changes of this PR are covered by test. Unit test were added with mocks when depending on a backend/device.
  • No impact: The changes of this PR have ZERO impact on the userland. Meaning, we can use these changes without modifying LLD/LLM at all. It will be a "noop" and the maintainers will be able to bump it without changing anything.

@ghost ghost self-assigned this Apr 15, 2022
@vercel
Copy link

vercel bot commented Apr 15, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ledgerhq/ledger-live-common/LAQUF5rwc2DoAnUfL85oMnXnRjvm
✅ Preview: Failed

@ghost ghost changed the title LIVE-1810 LIVE-1944 Update dependencies LIVE-1944 Update Polkadot dependencies Apr 15, 2022
@vercel
Copy link

vercel bot commented Apr 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ledger-live-common ❌ Failed (Inspect) Apr 19, 2022 at 0:32AM (UTC)

@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #1898 (98c14c6) into develop (87ffc67) will increase coverage by 3.12%.
The diff coverage is 75.00%.

❗ Current head 98c14c6 differs from pull request most recent head 7311373. Consider uploading reports for the commit 7311373 to get more accurate results

@@             Coverage Diff             @@
##           develop    #1898      +/-   ##
===========================================
+ Coverage    56.31%   59.44%   +3.12%     
===========================================
  Files          450      510      +60     
  Lines        20531    21104     +573     
  Branches      5267     5686     +419     
===========================================
+ Hits         11563    12545     +982     
+ Misses        8941     8538     -403     
+ Partials        27       21       -6     
Impacted Files Coverage Δ
src/families/bitcoin/wallet-btc/storage/index.ts 63.63% <60.00%> (-10.75%) ⬇️
src/families/bitcoin/js-synchronisation.ts 88.57% <100.00%> (-6.29%) ⬇️
src/families/bitcoin/wallet-btc/explorer/index.ts 82.73% <100.00%> (-5.76%) ⬇️
src/families/crypto_org/api/sdk.ts 16.85% <0.00%> (-78.66%) ⬇️
src/families/celo/hw-app-celo.ts 3.38% <0.00%> (-77.97%) ⬇️
src/families/bitcoin/js-signOperation.ts 21.53% <0.00%> (-75.39%) ⬇️
src/families/bitcoin/networks.ts 5.88% <0.00%> (-74.51%) ⬇️
src/families/celo/js-getFeesForTransaction.ts 26.66% <0.00%> (-73.34%) ⬇️
src/hw/signTransaction/ripple.ts 27.27% <0.00%> (-72.73%) ⬇️
src/families/celo/js-buildTransaction.ts 27.27% <0.00%> (-72.73%) ⬇️
... and 360 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87ffc67...7311373. Read the comment docs.

@ghost ghost marked this pull request as ready for review April 28, 2022 22:28
@ghost ghost self-requested a review as a code owner April 28, 2022 22:28
@ghost ghost merged commit 7d61755 into develop Apr 29, 2022
@ghost ghost deleted the support/update-dependencies branch April 29, 2022 08:15
This was referenced May 5, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants