Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

LIVE-2011 Revert "Use live common v22.0.0 for CLI and tools (#1885)" #1899

Merged
2 commits merged into from
Apr 21, 2022

Conversation

ghost
Copy link

@ghost ghost commented Apr 15, 2022

Context (issues, jira)

This reverts #1885
https://ledgerhq.atlassian.net/browse/LIVE-2011

Description / Usage

Tools don't build since #1885 this reverts use of live common from 22.0.0 to 21.34.0 (CLI as well)

Expectations

  • Test coverage: The changes of this PR are covered by test. Unit test were added with mocks when depending on a backend/device.
  • No impact: The changes of this PR have ZERO impact on the userland. Meaning, we can use these changes without modifying LLD/LLM at all. It will be a "noop" and the maintainers will be able to bump it without changing anything.

@ghost ghost requested a review from gre April 15, 2022 17:27
@ghost ghost self-requested a review as a code owner April 15, 2022 17:27
@vercel
Copy link

vercel bot commented Apr 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ledger-live-common ✅ Ready (Inspect) Visit Preview Apr 19, 2022 at 8:58AM (UTC)

@ghost ghost changed the title Revert "Use live common v22.0.0 for CLI and tools (#1885)" LIVE-2011 Revert "Use live common v22.0.0 for CLI and tools (#1885)" Apr 15, 2022
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #1899 (e246251) into develop (87ffc67) will increase coverage by 3.12%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1899      +/-   ##
===========================================
+ Coverage    56.31%   59.44%   +3.12%     
===========================================
  Files          450      510      +60     
  Lines        20531    21104     +573     
  Branches      5267     5686     +419     
===========================================
+ Hits         11563    12545     +982     
+ Misses        8941     8538     -403     
+ Partials        27       21       -6     
Impacted Files Coverage Δ
src/families/crypto_org/api/sdk.ts 16.85% <0.00%> (-78.66%) ⬇️
src/families/celo/hw-app-celo.ts 3.38% <0.00%> (-77.97%) ⬇️
src/families/bitcoin/js-signOperation.ts 21.53% <0.00%> (-75.39%) ⬇️
src/families/bitcoin/networks.ts 5.88% <0.00%> (-74.51%) ⬇️
src/families/celo/js-getFeesForTransaction.ts 26.66% <0.00%> (-73.34%) ⬇️
src/hw/signTransaction/ripple.ts 27.27% <0.00%> (-72.73%) ⬇️
src/families/celo/js-buildTransaction.ts 27.27% <0.00%> (-72.73%) ⬇️
src/families/elrond/api/sdk.ts 22.64% <0.00%> (-71.70%) ⬇️
src/families/solana/js-broadcast.ts 28.57% <0.00%> (-71.43%) ⬇️
src/families/crypto_org/js-signOperation.ts 20.31% <0.00%> (-70.32%) ⬇️
... and 357 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87ffc67...e246251. Read the comment docs.

cli/package.json Outdated Show resolved Hide resolved
@ghost ghost merged commit d63df6a into develop Apr 21, 2022
@ghost ghost deleted the bugfix/LIVE-2011-revert-tools branch April 21, 2022 10:30
@ghost ghost restored the bugfix/LIVE-2011-revert-tools branch April 21, 2022 12:13
lambertkevin pushed a commit that referenced this pull request Apr 22, 2022
* Revert "Use live common v22.0.0 for CLI and tools (#1885)"

This reverts commit 9c76b5d.

* revert the revert of cli and remove goerli

Co-authored-by: Henri Ly <[email protected]>
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants